Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports mp1s to obtain power information. #762

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Supports mp1s to obtain power information. #762

merged 1 commit into from
Apr 9, 2024

Conversation

Zrincet
Copy link
Contributor

@Zrincet Zrincet commented Jun 10, 2023

Context

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New device
  • New product id (the device is already supported with a different id)
  • New feature (which adds functionality to an existing device)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation

Additional information

  • This PR fixes issue: fixes mp1s incorrect method of obtaining power status
  • This PR is related to:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • The code has been formatted using Black.
  • The code follows the Zen of Python.
  • I am creating the Pull Request against the correct branch.
  • Documentation added/updated.

@Zrincet Zrincet mentioned this pull request Jun 10, 2023
Closed
@felipediel felipediel added the bug label Apr 9, 2024
@felipediel felipediel merged commit c6bf96d into mjg59:dev Apr 9, 2024
@felipediel
Copy link
Collaborator

Good job @Zrincet! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zrincet @felipediel