Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRV 0 0 0 . #240

Closed
bwbroersma opened this issue Nov 7, 2024 · 1 comment · Fixed by #241
Closed

SRV 0 0 0 . #240

bwbroersma opened this issue Nov 7, 2024 · 1 comment · Fixed by #241

Comments

@bwbroersma
Copy link
Contributor

Currently the 0 1 port . is used:

mox/mox-/admin.go

Lines 936 to 943 in 68c130f

// ../rfc/6186:242
"; Next records specify POP3 and non-TLS ports are not to be used.",
"; These are optional and safe to leave out (e.g. if you have to click a lot in a",
"; DNS admin web interface).",
fmt.Sprintf(`_imap._tcp.%s. SRV 0 1 143 .`, d),
fmt.Sprintf(`_submission._tcp.%s. SRV 0 1 587 .`, d),
fmt.Sprintf(`_pop3._tcp.%s. SRV 0 1 110 .`, d),
fmt.Sprintf(`_pop3s._tcp.%s. SRV 0 1 995 .`, d),

Instead of 0 0 0 ., like in the RFC examples of RFC 2782 or RFC 6186.

Is there any reason to include the port number and pick a weight of 1?
Note this RFC 2782 quote about the weight selection:

Domain administrators SHOULD use Weight 0 when there isn't any server selection to do, to make the RR easier to read for humans (less noisy).

BTW cool you already implemented these records, I was researching it for:

@mjl- mjl- closed this as completed in 3554880 Nov 10, 2024
mjl- added a commit that referenced this issue Nov 10, 2024
for issue #240, thanks bwbroersma for reporting and patch
@mjl-
Copy link
Owner

mjl- commented Nov 10, 2024

Excellent, thanks! I don't think I had a reason for not using weight 0. I wouldn't be surprised if I never looked at RFC 2782...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants