change path of tmp file for screenshots to respect relative paths #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "problem" we had when saving a screenshot for a file, which e.g. has relative path to images in the current working folder /root/emailA/... while the project folder is /root. Then the images are not displayed as the temporary file is sitting in some temporary folder of the OS. I changed it so that the temporary file is saved in the working folder. After taking all screenshots the file is deleted.
Of course one should never deploy a html file with relative folder, however during testing the marketing team might want to send some screenshots and in this case having the relative paths for images etc. is crucial.
Idea for another ticket: Having the HTML export actually warn via a dialog or so if relative paths were detected in the export ;)