-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request]: mjml as api service #340
Comments
hey @liminspace, thanks for posting this issue. We totally agree with you and are working on it, we're doing our best to deliver a MJML API as fast as possible! We'll keep you updated. |
We have implemented this as http://github.com/inventid/maily |
Hey guys (cc @liminspace, @cheacase, @caymanlad, @ipa1981, @encolpe), cool update for you here! We're opening the beta for the MJML API, here is a short typeform to request access: https://mjml.typeform.com/to/tW2U6K :-). Have fun! |
Very nice and convenient. |
Hello guys, as we released the API in Public Beta today (https://mjml.io/api), I'm closing this! Thanks and hope you'll like it :) |
Hi Nicholas,
This is excellent except that it would be excellent if we could download the API and host it internally on our own server. Is that possible?
Tim
|
Hey @caymanlad, sorry but we can't expose the internals of the API :( |
Hey @ngarnier, perhaps (in due course) you may reconsider allowing people to download the API and host it internally on their own servers? I work with a lot of companies where they would love to send better styled internal emails and using a cloud hosted API would not be an option for them considering the contents of these emails internal only emails (e.g. password reset for internal application, email notification about changes within an internal application etc.). |
ha ok I see, we'll keep that in mind then. And as they want to host it themselves, running MJML on a NodeJS server themselves is not an option either? |
If the reward for setting up a NodeJS server is that the client will have a better styled email, I suspect a lot of people would be willing to learn about what's required to stand one up. |
Agree with @caymanlad . We use MJML CLI, but we would really consider using MJML service + API to process emails just for much better performance running on localhost. For our client (the bank) processing such emails on 3rd party server is no go due to security policy. |
@ngarnier Is the typeform registration working? |
Hey Ed,
The typeform is for registering, it's not creating the key automatically.
I'm away from my computer for the weekend but I'll create your key on
Monday :-).
Cheers
Le sam. 27 mai 2017 à 19:31, Ed Wilson <notifications@github.com> a écrit :
… @ngarnier <https://github.com/ngarnier> Is the typeform registration
working?
I've applied for a key twice and had no email response :(
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#340 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEe6024aDJSLmXemjREXicxxxF7OLQ60ks5r-F3kgaJpZM4JTqIk>
.
|
I've applied for open beta, didn't receive email with credentials (I tried to apply twice), should I wait for it or? Is there a problem with open beta registration... |
hey @predragbabic, I just created your account on the API, you should have received them now :) |
@ngarnier, I tried to apply for the open beta api but haven't received any email either (as predragbabic). Can you help me out? |
@majkoll I had the same issue, they have a Slack channel that you can give them a prod on if you dont get a response :) |
Thanks for the info @ed0906. Just joined the channel |
Hey guys, when you fill and submit the form, you're just applying for the beta. We'll then create the credentials manually, so you just have to be a little patient 🙂 |
wow. I just created your keys @creativenoobie. Please avoid pinging the entire world next time you need help and can't wait, one comment is enough. MJML is open source, you can see the source code on that very same repo you're commenting, as well as the license. About the API source code, you probably wouldn't use it because it includes complexity layers that we need as we provide it as a service (free by the way). However, I doubt you would like to run services and databases to handle credentials management, user management, databases, load balancers, communication between different languages, etc etc. |
Thanks for the keys. |
@creativenoobie you can use your own API-service, it is not too difficult do write it by yourself. For example, I use my own solution based on TCP-server and it works very well on production. Code is here https://github.com/liminspace/django-mjml/blob/master/mjml/node/tcpserver.js |
@ngarnier Just got the Keys via mail. Could you please give me an example to use the same credentials on CURL as well as in Postman API request? |
@anand-gopinath See https://mjml.io/api/documentation/ e.g. |
Hey guys, I did github: https://github.com/Siepomaga/mjml-server |
Another mjml server implementation here: https://github.com/danihodovic/mjml-http-server |
this saved me today, I even made a pull request to update some things |
There is a free sponsored mjml api at http://mjml.dev if anyone needs one. I am the one who maintains it. |
Hi!
I use mjml and python/django by command mjml and pipe-line for pass template and get result.
It is very simple but very slow -- 0.8 - 2 seconds.
https://github.com/liminspace/django-mjml/blob/master/mjml/tools.py#L9
Then I try make tcp-server for keep mjml instance in process and I get better speed -- 0.1-0.2 seconds.
https://github.com/liminspace/django-mjml/blob/master/mjml/node/tcpserver.js
I am not good in node.js, so I propose you make mjml-api-server that other non-node.js services can use it as fast as possible.
The text was updated successfully, but these errors were encountered: