ttl: const default ttl job interval (pingcap#53512)

ref pingcap#53520
mjonss · May 24, 2024 · 8f958de · 8f958de
1 parent 9657f06
commit 8f958de
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/pkg/ddl/ttl.go b/pkg/ddl/ttl.go
@@ -31,6 +31,9 @@ import (
 	"github.com/pingcap/tidb/pkg/util/dbterror"
 )
 
+// DefaultTTLJobInterval is the default value for ttl job interval.
+const DefaultTTLJobInterval = "1h"
+
 func onTTLInfoRemove(d *ddlCtx, t *meta.Meta, job *model.Job) (ver int64, err error) {
 	tblInfo, err := GetTableInfoAndCancelFaultJob(t, job, job.SchemaID)
 	if err != nil {
@@ -201,7 +204,7 @@ func getTTLInfoInOptions(options []*ast.TableOption) (ttlInfo *model.TTLInfo, tt
 				IntervalExprStr:  intervalExpr,
 				IntervalTimeUnit: int(op.TimeUnitValue.Unit),
 				Enable:           true,
-				JobInterval:      "1h",
+				JobInterval:      DefaultTTLJobInterval,
 			}
 		case ast.TableOptionTTLEnable:
 			ttlEnable = &op.BoolValue

diff --git a/pkg/ddl/ttl_test.go b/pkg/ddl/ttl_test.go
@@ -55,7 +55,7 @@ func Test_getTTLInfoInOptions(t *testing.T) {
 				IntervalExprStr:  "5",
 				IntervalTimeUnit: int(ast.TimeUnitYear),
 				Enable:           true,
-				JobInterval:      "1h",
+				JobInterval:      DefaultTTLJobInterval,
 			},
 			nil,
 			nil,
@@ -79,7 +79,7 @@ func Test_getTTLInfoInOptions(t *testing.T) {
 				IntervalExprStr:  "5",
 				IntervalTimeUnit: int(ast.TimeUnitYear),
 				Enable:           false,
-				JobInterval:      "1h",
+				JobInterval:      DefaultTTLJobInterval,
 			},
 			&falseValue,
 			nil,
@@ -107,7 +107,7 @@ func Test_getTTLInfoInOptions(t *testing.T) {
 				IntervalExprStr:  "5",
 				IntervalTimeUnit: int(ast.TimeUnitYear),
 				Enable:           true,
-				JobInterval:      "1h",
+				JobInterval:      DefaultTTLJobInterval,
 			},
 			&trueValue,
 			nil,