Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in some tests #82

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add in some tests #82

wants to merge 2 commits into from

Conversation

whikloj
Copy link
Contributor

@whikloj whikloj commented May 18, 2022

I'm not going to go crazy here, but I need tests to see how things are meant to operate so I figured if I was writing them, you might want them. But you can close this too.

CAUTION if you do want these tests then please be aware that the composer.lock and the test structure only goes to PHP 7.3 as I no longer have access to a 7.2 instance to update the lock file.

So if you want to support 7.2, you would need to

  1. Using PHP 7.2 run composer update
  2. Add that updated composer.lock to this PR
  3. Add "7.2" as one of the php-versions in the ci_workflow.yml below. (line 24)

Also this duplicates some of the changes in #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant