Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not going to go crazy here, but I need tests to see how things are meant to operate so I figured if I was writing them, you might want them. But you can close this too.
CAUTION if you do want these tests then please be aware that the
composer.lock
and the test structure only goes to PHP 7.3 as I no longer have access to a 7.2 instance to update the lock file.So if you want to support 7.2, you would need to
composer update
composer.lock
to this PRphp-versions
in theci_workflow.yml
below. (line 24)Also this duplicates some of the changes in #81