Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests rely on your laptop #38

Closed
whikloj opened this issue Mar 28, 2019 · 1 comment
Closed

Tests rely on your laptop #38

whikloj opened this issue Mar 28, 2019 · 1 comment

Comments

@whikloj
Copy link
Contributor

whikloj commented Mar 28, 2019

Ok so some debugging from my comments on #37 results in this issue that your tests rely on resources on your laptop. You will need to move those items into the code base as test resources and then reference them more relatively.

Testing App\Tests\Command\CheckFixityCommandTest
stdClass::__set_state(array(
   'resource_id' => '/home/mark/Documents/hacking/riprap/resources/filesystemexample/resourcefiles/file1.bin',
   'last_modified_timestamp' => '2018-10-28T19:04:20-0800',
))

Error : Call to a member function warning() on null
 /sw/var/www/DAM2/riprap/src/Plugin/PluginFetchDigestFromShell.php:28
 /sw/var/www/DAM2/riprap/src/Command/CheckFixityCommand.php:117
 /sw/var/www/DAM2/riprap/vendor/symfony/console/Command/Command.php:255
 /sw/var/www/DAM2/riprap/vendor/symfony/console/Tester/CommandTester.php:76
 /sw/var/www/DAM2/riprap/tests/Command/CheckFixityCommandTest.php:26

So it is trying to fetch the file and it doesn't exist so it errors out.

mjordan added a commit that referenced this issue Mar 31, 2019
mjordan added a commit that referenced this issue Mar 31, 2019
@mjordan
Copy link
Owner

mjordan commented Mar 31, 2019

Thanks for catching this @whikloj.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants