Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup black for CI #477

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Conversation

JohnVillalovos
Copy link
Contributor

@JohnVillalovos JohnVillalovos commented Jun 23, 2022

Commit f072340 ran black on the
code base. But since it wasn't being enforced in the CI, it has
drifted away from black standarized formatting.

Did the following:

  • Added a Github CI job to run black
  • Added a black tox environment
  • Ran black on the code
  • Added the requirements-dev.txt file

This has been setup so that it should be easy to add other
checkers/linters in the future as desired.

@NicolasLM
Copy link
Collaborator

Could we put all the dependencies in a requirements-dev.txt just to make it clear that the project doesn't have any dependency when using it as a library?

Copy link
Owner

@mjs mjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great aside from the concern Nicolas raised.
Thanks very much!

Commit f072340 ran `black` on the
code base. But since it wasn't being enforced in the CI, it has
drifted away from `black` standarized formatting.

Did the following:
  * Added a Github CI job to run `black`
  * Added a `black` tox environment
  * Ran `black` on the code
  * Added the `requirements-dev.txt` file

This has been setup so that it should be easy to add other
checkers/linters in the future as desired.
@JohnVillalovos
Copy link
Contributor Author

Could we put all the dependencies in a requirements-dev.txt just to make it clear that the project doesn't have any dependency when using it as a library?

Done! 😊

@JohnVillalovos JohnVillalovos requested a review from mjs June 23, 2022 13:35
@NicolasLM
Copy link
Collaborator

Perfect, thanks!

@NicolasLM NicolasLM merged commit c2441dd into mjs:master Jun 23, 2022
@JohnVillalovos JohnVillalovos deleted the jlvillal/black_todo branch June 23, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants