Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup flake8, fix issues, & add to CI #478

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

JohnVillalovos
Copy link
Contributor

  • Setup flake8 as a tox environment
  • Fix issues flagged by flake8
  • Add running of flake8 in the CI

@JohnVillalovos
Copy link
Contributor Author

Unsure if you are interested in having this check or not. But I figured why not propose it 🙂

@JohnVillalovos JohnVillalovos marked this pull request as draft June 23, 2022 15:42
  * Setup `flake8` as a tox environment
  * Fix issues flagged by `flake8`
  * Add running of `flake8` in the CI
@JohnVillalovos JohnVillalovos marked this pull request as ready for review June 23, 2022 16:21
Copy link
Owner

@mjs mjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic. Thank you.

@mjs mjs merged commit 92255e9 into mjs:master Jun 28, 2022
@JohnVillalovos JohnVillalovos deleted the jlvillal/black branch September 27, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants