Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove support for Python 3.4 & 3.5. Support Python 3.10 #483

Merged
merged 1 commit into from
Jul 10, 2022

Conversation

JohnVillalovos
Copy link
Contributor

@JohnVillalovos JohnVillalovos commented Jul 9, 2022

  • Update the code and docs to remove support for Python 3.4 and 3.5.
  • State that Python 3.10 is supported.
  • Add Python 3.10 to the testing in the CI

Closes: #479

Copy link
Owner

@mjs mjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one thing

tox.ini Show resolved Hide resolved
  * Update the code and docs to remove support for Python 3.4 and 3.5.
  * State that Python 3.10 is supported.
  * Add Python 3.10 to the testing in the CI

Closes: mjs#479
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/drop_py_34_35 branch from 658e533 to 4879686 Compare July 9, 2022 15:07
@mjs
Copy link
Owner

mjs commented Jul 10, 2022

Fabulous. Thanks again!

@mjs mjs merged commit 309dd77 into mjs:master Jul 10, 2022
@JohnVillalovos JohnVillalovos deleted the jlvillal/drop_py_34_35 branch September 27, 2022 15:47
@mjs mjs added semver-major breaking Breaking change the requires a major version bump labels Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change the requires a major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.4
2 participants