Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial framework for adding type-hints and added type-hints to version.py #518

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

JohnVillalovos
Copy link
Contributor

This is adding the initial framework for adding type-hints. It adds the running of mypy and type-checks nothing in the first commit.

Then adds type-checking of the file imapclient/version.py and others can use that as an example of how to add type-hints by updating pyproject.toml

@NicolasLM
Copy link
Collaborator

Looks good to me, although given the low activity on IMAPClient in the past few of years, I doubt type hints will ever be populated on a significant portion of the code.

@mjs
Copy link
Owner

mjs commented Aug 22, 2023

Still worth it I think

@mjs mjs merged commit 49dde75 into mjs:master Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants