[Hub Generated] Review request for Microsoft.KeyVault to add version …

…preview/2020-04-01-preview (Azure#12619)
mkarmark · Jul 20, 2021 · 49dcb68 · 49dcb68
1 parent 7b79f10
commit 49dcb68
Show file tree

Hide file tree

Showing 5 changed files with 180 additions and 0 deletions.
diff --git a/.../resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/examples/createVault.json b/.../resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/examples/createVault.json
@@ -84,6 +84,21 @@
             "name": "standard"
           },
           "tenantId": "00000000-0000-0000-0000-000000000000",
+          "networkAcls": {
+            "bypass": "AzureServices",
+            "defaultAction": "Deny",
+            "ipRules": [
+              {
+                "value": ""
+              }
+            ],
+            "virtualNetworkRules": [
+              {
+                "id": "",
+                "ignoreMissingVnetServiceEndpoint": false
+              }
+            ]
+          },
           "accessPolicies": [
             {
               "tenantId": "00000000-0000-0000-0000-000000000000",
@@ -136,6 +151,21 @@
               }
             }
           ],
+          "privateEndpointConnections": [
+            {
+              "id": "",
+              "properties": {
+                "provisioningState": "Succeeded",
+                "privateEndpoint": {
+                  "id": ""
+                },
+                "privateLinkServiceConnectionState": {
+                  "status": "Approved",
+                  "actionsRequired": "None"
+                }
+              }
+            }
+          ],
           "enabledForDeployment": true,
           "enabledForDiskEncryption": true,
           "enabledForTemplateDeployment": true,

diff --git a/...source-manager/Microsoft.KeyVault/preview/2020-04-01-preview/examples/listOperations.json b/...source-manager/Microsoft.KeyVault/preview/2020-04-01-preview/examples/listOperations.json
@@ -94,6 +94,36 @@
                     "displayName": "Audit Logs",
                     "blobDuration": "PT1H"
                   }
+                ],
+                "metricSpecifications": [
+                  {
+                    "name": "ServiceApiHit",
+                    "displayName": "",
+                    "displayDescription": "",
+                    "unit": "",
+                    "aggregationType": "",
+                    "supportedAggregationTypes": [
+                      ""
+                    ],
+                    "supportedTimeGrainTypes": [
+                      ""
+                    ],
+                    "lockAggregationType": "",
+                    "dimensions": [
+                      {
+                        "name": "ActivityType",
+                        "displayName": "",
+                        "toBeExportedForShoebox": true
+                      },
+                      {
+                        "name": "ActivityName",
+                        "displayName": "",
+                        "toBeExportedForShoebox": true
+                      }
+                    ],
+                    "fillGapWithZero": false,
+                    "internalMetricName": "AuditEvent"
+                  }
                 ]
               }
             }

diff --git a/.../resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/examples/updateVault.json b/.../resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/examples/updateVault.json
@@ -83,6 +83,21 @@
             "name": "standard"
           },
           "tenantId": "00000000-0000-0000-0000-000000000000",
+          "networkAcls": {
+            "bypass": "AzureServices",
+            "defaultAction": "Deny",
+            "ipRules": [
+              {
+                "value": ""
+              }
+            ],
+            "virtualNetworkRules": [
+              {
+                "id": "",
+                "ignoreMissingVnetServiceEndpoint": false
+              }
+            ]
+          },
           "accessPolicies": [
             {
               "tenantId": "00000000-0000-0000-0000-000000000000",
@@ -135,6 +150,21 @@
               }
             }
           ],
+          "privateEndpointConnections": [
+            {
+              "id": "",
+              "properties": {
+                "provisioningState": "Succeeded",
+                "privateEndpoint": {
+                  "id": ""
+                },
+                "privateLinkServiceConnectionState": {
+                  "status": "Approved",
+                  "actionsRequired": "None"
+                }
+              }
+            }
+          ],
           "enabledForDeployment": true,
           "enabledForDiskEncryption": true,
           "enabledForTemplateDeployment": true,

diff --git a/...ion/keyvault/resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/keyvault.json b/...ion/keyvault/resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/keyvault.json
@@ -1761,6 +1761,10 @@
         "id": {
           "type": "string",
           "description": "Full resource id of a vnet subnet, such as '/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/subnet1'."
+        },
+        "ignoreMissingVnetServiceEndpoint": {
+          "type": "boolean",
+          "description": "Property to specify whether NRP will ignore the check if parent subnet has serviceEndpoints configured."
         }
       },
       "required": [
@@ -1770,6 +1774,10 @@
     },
     "PrivateEndpointConnectionItem": {
       "properties": {
+        "id": {
+          "type": "string",
+          "description": "Id of private endpoint connection."
+        },
         "properties": {
           "$ref": "#/definitions/PrivateEndpointConnectionProperties",
           "x-ms-client-flatten": true,

diff --git a/...on/keyvault/resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/providers.json b/...on/keyvault/resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/providers.json
@@ -139,6 +139,13 @@
           "items": {
             "$ref": "#/definitions/LogSpecification"
           }
+        },
+        "metricSpecifications": {
+          "description": "Metric specifications of operation.",
+          "type": "array",
+          "items": {
+            "$ref": "#/definitions/MetricSpecification"
+          }
         }
       }
     },
@@ -158,6 +165,81 @@
           "description": "Blob duration of specification."
         }
       }
+    },
+    "MetricSpecification": {
+      "description": "Metric specification of operation.",
+      "properties": {
+        "name": {
+          "type": "string",
+          "description": "Name of metric specification."
+        },
+        "displayName": {
+          "type": "string",
+          "description": "Display name of Metric specification."
+        },
+        "displayDescription": {
+          "type": "string",
+          "description": "Display description of Metric specification."
+        },
+        "unit": {
+          "type": "string",
+          "description": "The metric unit. Possible values include: 'Bytes', 'Count', 'Milliseconds'."
+        },
+        "aggregationType": {
+          "type": "string",
+          "description": "The metric aggregation type. Possible values include: 'Average', 'Count', 'Total'."
+        },
+        "supportedAggregationTypes": {
+          "type": "array",
+          "description": "The supported aggregation types for the metrics.",
+          "items": {
+            "type": "string"
+          }
+        },
+        "supportedTimeGrainTypes": {
+          "type": "array",
+          "description": "The supported time grain types for the metrics.",
+          "items": {
+            "type": "string"
+          }
+        },
+        "lockAggregationType": {
+          "type": "string",
+          "description": "The metric lock aggregation type."
+        },
+        "dimensions": {
+          "type": "array",
+          "description": "The dimensions of metric.",
+          "items": {
+            "$ref": "#/definitions/DimensionProperties"
+          }
+        },
+        "fillGapWithZero": {
+          "type": "boolean",
+          "description": "Property to specify whether to fill gap with zero."
+        },
+        "internalMetricName": {
+          "type": "string",
+          "description": "The internal metric name."
+        }
+      }
+    },
+    "DimensionProperties": {
+      "description": "Type of operation: get, read, delete, etc.",
+      "properties": {
+        "name": {
+          "type": "string",
+          "description": "Name of dimension."
+        },
+        "displayName": {
+          "type": "string",
+          "description": "Display name of dimension."
+        },
+        "toBeExportedForShoebox": {
+          "type": "boolean",
+          "description": "Property to specify whether the dimension should be exported for shoebox."
+        }
+      }
     }
   },
   "parameters": {