Fix inheritance logic when intermediate class is present #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…intermediate class.
pawamoy
requested changes
Nov 5, 2024
thomasmarwitz
force-pushed
the
fix-intermediate-inheritance
branch
2 times, most recently
from
a8e0884 to
5762c89
Compare
|
I tried this locally, and unfortunately the test passes even without the fix. |
thomasmarwitz
force-pushed
the
fix-intermediate-inheritance
branch
from
5762c89 to
f5eacd5
Compare
pawamoy
reviewed
Nov 5, 2024
…tz/griffe-inherited-docstrings into fix-intermediate-inheritance
Co-authored-by: Timothée Mazzucotelli <dev@pawamoy.fr>
…tz/griffe-inherited-docstrings into fix-intermediate-inheritance
pawamoy
approved these changes
Nov 5, 2024
|
Thanks for double-checking everything :) |
|
Released in v1.1.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4