-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
overloads without implementations (in stub files) are not detected #116
Comments
Thanks for the report! |
the repo i found it on was that same (compiled)
def test_overloads():
import griffe
core = griffe.load('pymmcore.CMMCore')
# defineConfig is overloaded
assert 'defineConfig' in core.members
# this is a non-overloaded function that works already
assert 'addSearchPath' in core.members and the corresponding stub is at https://github.com/micro-manager/pymmcore/blob/main/pymmcore/__init__.pyi |
Ah, found the issue. It's because we merge stubs before wildcard imports were expanded. |
Another issue is that An argument in favor of the |
OK, we need #115 first. |
Fixed in 0ed9c36 |
Describe the bug
Methods and functions that are decorated with
@overload
but do not have an implementation (as is standard in a stub file) are not detected:To Reproduce
Expected behavior
Expected
f
method to be detected.System (please complete the following information):
griffe
version: 0.24.1Will probably be relevant for mkdocstrings/mkdocstrings#308 as well
The text was updated successfully, but these errors were encountered: