Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning with Python 3.12.0b4 #179

Closed
juergenzimmermann opened this issue Jul 15, 2023 · 4 comments
Closed

Deprecation warning with Python 3.12.0b4 #179

juergenzimmermann opened this issue Jul 15, 2023 · 4 comments

Comments

@juergenzimmermann
Copy link

Describe the bug
Actually a hint, not really a bug: Experimenting with Python 3.12.0b4 gives 2 deprecation warnings:

  • .venv\Lib\site-packages\griffe\agents\nodes_values.py, line 21
  • .venv\Lib\site-packages\griffe\agents\nodes_docstrings.py", line 8

Debug logs

$ mkdocs build -v
...
DEBUG    -  mkdocstrings: Using handler 'python'
INFO     -  DeprecationWarning: ast.Ellipsis is deprecated and will be removed in Python 3.14; use ast.Constant instead
              File "C:\Zimmermann\Python\Lib\warnings.py", line 529, in _deprecated
                warn(msg, DeprecationWarning, stacklevel=3)
              File "C:\workspace\python\flaskapp\.venv\Lib\site-packages\griffe\agents\nodes\_values.py", line 21, in
                from ast import Ellipsis as NodeEllipsis
INFO     -  DeprecationWarning: ast.Str is deprecated and will be removed in Python 3.14; use ast.Constant instead
              File "C:\Zimmermann\Python\Lib\warnings.py", line 529, in _deprecated
                warn(msg, DeprecationWarning, stacklevel=3)
              File "C:\workspace\python\flaskapp\.venv\Lib\site-packages\griffe\agents\nodes\_docstrings.py", line 8, in
                from ast import Str as NodeStr

To Reproduce
Any project using mkdocs and mkdocstrings, but Python 3.12.0b4

Expected behavior
No (annoying) warning.

System (please complete the following information):

  • griffe version: 0.32.0
  • Python version: 3.12.0b4
  • OS: Windows 11 Enterprise 22H2
@pawamoy
Copy link
Member

pawamoy commented Jul 15, 2023

Thanks for the heads up! I'm waiting for LXML to release its v5, compatible with Python 3.12, before I can actually run CI on 3.12. And I think LXML is waiting for 3.12.0 to be released 😕

@pawamoy
Copy link
Member

pawamoy commented Jul 15, 2023

Ah, v4.9.3 actually provides wheels for Python 3.12, great! Will then fix this ASAP 🙂

@juergenzimmermann
Copy link
Author

@pawamoy Thank you for the immediate fix. It works fine.

@pawamoy
Copy link
Member

pawamoy commented Jul 15, 2023

Thanks for testing and confirming it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants