Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API checks: Improve reporting for attribute who lost their value #218

Closed
pawamoy opened this issue Oct 10, 2023 · 0 comments
Closed

API checks: Improve reporting for attribute who lost their value #218

pawamoy opened this issue Oct 10, 2023 · 0 comments
Assignees
@pawamoy

Comments

@pawamoy
Copy link
Member

pawamoy commented Oct 10, 2023

Describe the bug
For example, going from:

class A:
    b: int | None = None

to

class A:
    b: int

will report

src/package/module.py:2: A.b: Attribute value was changed: None -> None

I think it should say "unset" instead of None?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawamoy pawamoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pawamoy