-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Maybe rework the logic for objects lines
or source
#272
Comments
|
pawamoy
added a commit
that referenced
this issue
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following #271, and now that Griffe can inspect everything even when sources are found, maybe we should rework how
lines
and thereforesource
are computed. If possible, when inspecting and sources are available (and added to the lines collection), we should try to obtain thelineno
andendlineno
values frominspect
(stdlib). If the sources are not available (no filepath, and/or no entry in the lines collection), we should still try to obtain the source withinspect
(stdlib) to set thesource
attribute of the object. To allow settingsource
, we should keep the actual source in a_source
attribute, and the property would first check that.The text was updated successfully, but these errors were encountered: