Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Log debug instead of errors when failing to parse NumPy annotations for additional sections #109

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Conversation

sisp
Copy link
Contributor

@sisp sisp commented Oct 26, 2022

I've fixed support for NumPy annotations, that aren't conformant with PEP 484, for additional docstring sections:

  • Attributes
  • Returns
  • Receives
  • Yields

Follow-up of 75eeeda. Fixes #93 (comment).

@pawamoy pawamoy self-assigned this Oct 26, 2022
@pawamoy
Copy link
Member

pawamoy commented Oct 26, 2022

CI failures unrelated to your changes, I'll fix them.

@pawamoy
Copy link
Member

pawamoy commented Oct 26, 2022

Can you git rebase master please?

@sisp
Copy link
Contributor Author

sisp commented Oct 26, 2022

Done. 👍

Copy link
Member

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's perfect, thanks a lot @sisp!

@pawamoy pawamoy merged commit 568ff60 into mkdocstrings:master Oct 26, 2022
@sisp sisp deleted the fix/numpy-text-annotations branch October 28, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boolean operation in NumPy-style type annotation raises error
2 participants