feat: Implement basic handling of Alias for breaking changes #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Georggi
force-pushed
the
add_alias_check
branch
3 times, most recently
from
d1a3e28
to
dc89f16
Compare
|
Thanks a lot! Could you add some tests? |
Georggi
force-pushed
the
add_alias_check
branch
4 times, most recently
from
8a6b0af
to
b7ea38d
Compare
|
Thanks for the update. Since both tests are very similar, I'd prefer that we combine them, if possible (easier to maintain). I'll try to do that if you don't mind. |
|
Just pushed my changes. Let me know what you think. IMO it's looking good and we can merge 🙂 |
|
My only concern is that we removed a more basic case with no alias. I think there should still be a separate assert at least that would not include init module. |
pawamoy
force-pushed
the
add_alias_check
branch
from
1f07573
to
2f2e0f6
Compare
|
Good point, I've added back tests without aliases 🙂 |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.