feat: Add --version and -V cli flag.
#187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgarte
added a commit
to jgarte/griffe
that referenced
this pull request
Jul 25, 2023
jgarte
added a commit
to jgarte/griffe
that referenced
this pull request
Jul 25, 2023
jgarte
added a commit
to jgarte/griffe
that referenced
this pull request
Jul 25, 2023
jgarte
added a commit
to jgarte/griffe
that referenced
this pull request
Jul 25, 2023
jgarte
added a commit
to jgarte/griffe
that referenced
this pull request
Jul 25, 2023
jgarte
added a commit
to jgarte/griffe
that referenced
this pull request
Jul 25, 2023
pawamoy
requested changes
Jul 26, 2023
There was a problem hiding this comment.
Thanks for the PR!
See my comments. If you think it's better to hardcode the version (I know it has benefits), then we should also automate its update through PDM: https://pdm-backend.fming.dev/metadata/#writing-dynamic-version-to-file.
jgarte
added a commit
to jgarte/griffe
that referenced
this pull request
Jul 26, 2023
jgarte
added a commit
to jgarte/griffe
that referenced
this pull request
Jul 26, 2023
|
Hi @pawamoy, is there anything I should change/update in this PR that you haven't mentioned yet? |
|
Didn't get time to review again, will do tomorrow 🙂 |
pawamoy
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds
--versionand-Vcommand line flags togriffe.Should I also add the version information to the common options?
This PR also closes #186.
I also added two commits fixing a typo in a docstring and improving the return description.
Screenshot