Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix dataclass parameters to exclude properties #248

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

has2k1
Copy link
Contributor

@has2k1 has2k1 commented Mar 11, 2024

This was fixed in 5a5c03b, but broken in 82a9d57. The tests
broke as well and did not catch the regression.

This was fixed in 5a5c03b, but broken in 82a9d57. The tests
broke as well and did not catch the regression.
Copy link
Member

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@pawamoy pawamoy merged commit 8c48397 into mkdocstrings:main Mar 11, 2024
17 checks passed
@has2k1 has2k1 deleted the fix-dataclass-parameters branch March 11, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants