fix: retrieve default value for non-string parameters #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawamoy
requested changes
Mar 31, 2022
There was a problem hiding this comment.
Thanks a lot!
Could you also add tests for this? You can get inspiration from test_building_annotations_from_nodes in test_nodes.py. Let me know if you need more hints.
We should test simple defaults like strings, integers, floats and booleans, but also more complex expressions like DEFAULT_DICT["key1"], as you showed in #59 🙂
|
Alright I added some tests to the PR ;) |
pawamoy
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should solve #59 and this issue from
mkdocstrings-python