Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No type declaration of "Function" and "Property Get" possible #17

Closed
juengling opened this issue Aug 7, 2024 · 2 comments · Fixed by #21
Closed

No type declaration of "Function" and "Property Get" possible #17

juengling opened this issue Aug 7, 2024 · 2 comments · Fixed by #21
Assignees

Comments

@juengling
Copy link

juengling commented Aug 7, 2024

(Mkdocs v1.6.0, Python 3.12 on Windows 11)

You cannot specify a return type of a "Function" or a "Property Get". Anything before the ":" is reported as its "name". Unfortunately the type is not recognize from the property declaration (as it ist done for the "property let").

But in this case the command line complains with a warning: WARNING - griffe: <module>:9: No type or annotation for returned value 'String'

Example:

Public Property Get Text() As String
' Retrieve Text property
'
' Returns:
'	String: Text property value
Text = MyString

End Property

Result:

grafik

Trying the same example with a dummy name plus a type results in an endless loop, which terminates with RecursionError: maximum recursion depth exceeded.

' Returns:
'	Dummy (String): Text property value

See a minimum working example on Gitlab.

@rudolfbyker rudolfbyker self-assigned this Aug 7, 2024
@juengling juengling changed the title No type declaration of "Property Get" possible No type declaration of "Function" and "Property Get" possible Aug 7, 2024
@juengling
Copy link
Author

Same with Functions, I edited the title and description accordingly.

@rudolfbyker
Copy link
Collaborator

Thanks for reporting. Please review #21

rudolfbyker added a commit that referenced this issue Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants