Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for error before checking for data end #3

Merged
merged 1 commit into from
Jan 31, 2018

Conversation

AquiGorka
Copy link
Contributor

@AquiGorka AquiGorka commented Jan 31, 2018

I was getting an error in the lines of: "cannot read end of undefined" which meant data was undefined. Maybe this was happening because an error was being sent but the check for it happened after trying to access data.end

I changed this locally and the error stopped.

@codecov
Copy link

codecov bot commented Jan 31, 2018

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #3   +/-   ##
=======================================
  Coverage   89.88%   89.88%           
=======================================
  Files           1        1           
  Lines          89       89           
=======================================
  Hits           80       80           
  Misses          9        9
Impacted Files Coverage Δ
src/index.js 89.88% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60a56d...753b1f0. Read the comment docs.

@mkg20001
Copy link
Owner

Thanks!

@mkg20001 mkg20001 merged commit 7384c18 into mkg20001:master Jan 31, 2018
@AquiGorka
Copy link
Contributor Author

AquiGorka commented Jan 31, 2018

I assume you'll update js-libp2p-websocket-star and we'll have to ask js-ipfs to update accordingly.

@mkg20001
Copy link
Owner

I think there is no need to update that there as it's currently being rewritten anyways
PR: libp2p/js-libp2p-websocket-star#43 - just waiting for that to get reviewed

@AquiGorka
Copy link
Contributor Author

Oh, ok. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants