Better maxslice size to avoid problems on ARM #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests fixes (if I'm not wrong) the issue #3 where compiling goejdb in raspberry pi (and in my case in an scaleway arm server) was giving some problems.
The compile problem was this:
It seems that the const
maxslicewas too big. But how much? It seems it's a hot issue as seen here golang/go#13656 So I took the approach to see what other projects where doing, in this case bolt and in theirbolt_*files they use a 2GB address space.So that's the first change, reduced the address space to 2GB. After that still this needs to be divided by the size of the item in the array or again the compiler will rise the error.
What do you think?