Skip to content

inliner task #31

Open
Open
@mklabs

Description

@mklabs

Just found out about https://github.com/remy/inliner is a fantastic package, we should use it, or at least take inspiration from.

  • have a super nice api ->eventemitter.
  • build a list of all assets used
    • all inline images and base64 encode
    • all external style sheets
    • all image references in CSS
  • even supports css inlining (we now do this through rjs)
  • can convert img as based64 data urls in both html and css
  • inline scripts / styles

It does however a few thing that we likely already do.

  • a bit of feature overlapping
  • relies on jsdom, so that will be a pain for windows user

It can also be the main handler for the dom-based build. Also thinking of playing with substack/node-trumpet to rely on a streaming html parser and remove the need of jsdom or cheerio.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions