fluent-builder: improve inheritance handling #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for super() calls to compile using inherited with*() methods.
This allows using Buildable with xjc episodes.
|
Thanks for the quick merge! Would it be possible to have a new release with the merged commits? |
|
The new release is already published (4.2.1.2) on maven central, however it doesn’t seem to be publicly visible yet.Maybe try a bit later…Mirko KlemmHermannstädter Straße 1053119 BonnAm 13.09.2024 um 12:24 schrieb Zsombor Welker ***@***.***>:
Thanks for the quick merge! Would it be possible to have a new release with the merged commits?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your work @mklemm! While updating from an older version we found two corner-cases related to fluent-builder inheritance handling which this PR improves:
with*()methods were not generated for superclasses due to differing checks. This was corrected by using the same checks to determine if the methods should be generated. (6edaa7d, Inheritance is creating empty builder methods #79)when extending classes from previous runs of
xjcusing episodes theBuilderinner classes were not found. This was corrected by modifying theisLocal()checks to also look at existing classes. (c5159fa)Failing tests are added for both cases (ad02367, a5d93ef) using extracts from the SIRI and NeTEx standards, which pass after the relevant commits.