Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade rubocop to version 1.31.1 #162

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Upgrade rubocop to version 1.31.1 #162

merged 1 commit into from
Jul 19, 2022

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Jul 6, 2022

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (1.29.1 → 1.31.1) · Repo · Changelog

Release Notes

1.31.1

Bug fixes

  • #10763: Fix a false positive for Layout/LineContinuationSpacing when using continuation keyword \ after __END__. (@koic)
  • #10755: Fix a false positive for Lint/LiteralAsCondition when using a literal in case-in condition where the match variable is used in in are accepted as a pattern matching. (@koic)
  • #10760: Fix a false positive for Lint/NonAtomicFileOperation when using FileTest.exist? with if condition that has else branch. (@koic)
  • #10745: Require JSON 2.3 or higher to fix an incompatible JSON API error. (@koic)
  • #10754: Fix an incorrect autocorrect for Style/HashExcept when using a non-literal collection receiver for include?. (@koic)
  • #10751: Fix autocorrect for Layout/FirstHashElementIndentation. (@j-miyake)
  • #10750: Recover 7x slow running rubocop. (@koic)

1.31.0

New features

  • #10699: Add new global ActiveSupportExtensionsEnabled option. (@nobuyo)
  • #10245: Add specification_version and rubygems_version to Gemspec/DeprecatedAttributeAssignment. (@kaitielth)
  • #10696: Add new Lint/NonAtomicFileOperation cop. (@ydah)
  • #6420: Add new Layout/LineContinuationLeadingSpace cop. (@bquorning)
  • #6420: Add new Layout/LineContinuationSpacing cop. (@bquorning)
  • #10706: Integrate rubocop-daemon to add server options. (@koic)
  • #10722: Add new Lint/ConstantOverwrittenInRescue cop. (@ydah)

Bug fixes

  • #10700: Update Style/EmptyMethod to not correct if the correction would exceed the configuration for Layout/LineLength. (@dvandersluis)
  • #10698: Enhance Style/HashExcept to support array inclusion checks. (@nobuyo)
  • #10734: Handle ClobberingError in Style/NestedTernaryOperator when there are multiple nested ternaries. (@dvandersluis)
  • #10689: Fix autocorrect for Layout/FirstHashElementIndentation and Layout/FirstArrayElementIndentation. (@j-miyake)
  • Fix rubocop -V not displaying the version information for rubocop-graphql, rubocop-md and rubocop-thread_safety. (@Darhazer)
  • #10711: Fix an error for Style/MultilineTernaryOperator when the false branch is on a separate line. (@koic)
  • #10719: Fix a false positive for Lint/ParenthesesAsGroupedExpression when using safe navigation operator. (@koic)
  • #10736: Fix Layout/SpaceInsideBlockBraces for blocks with numbered arguments. (@gsamokovarov)
  • #10749: Fix Style/BlockDelimiters for blocks with numbered arguments. (@gsamokovarov)
  • #10737: Fix crash in Style/ConditionalAssignment with EnforcedStyle: assign_inside_condition when op-assigning a variable inside a resbody. (@dvandersluis)
  • #7900: Fix Style/FormatStringToken false positive with formatted input and template style enforced, and add autocorrection. (@FnControlOption)

Changes

  • #10730: Change output timing of GitHubActionsFormatter. (@r7kamura)
  • #10709: Deprecate rubocop:auto_correct custom rake task and newly split rubocop:autocorrect and rubocop:autocorrect-all custom rake tasks. (@koic)
  • #9760: Change RangeHelp#range_with_surrounding_space to allow passing the range as a positional argument. (@pirj)
  • #10693: Add ignore case for Style/EmptyLinesAroundAttributeAccessor when there is a comment line on the next line. (@ydah)
  • #10245: (Breaking) integrate Gemspec/DateAssignment into Gemspec/DeprecatedAttributeAssignment. (@kaitielth)
  • #10697: Restore Lint/UselessElseWithoutRescue cop. (@koic)
  • #10740: Make Style/GuardClause a bit more lenient when the replacement would make the code more verbose. (@dvandersluis)

1.30.1

Bug fixes

  • #10685: Fix a false positive for Style/StringConcatenation when Mode: conservative and first operand is not string literal. (@koic)
  • #10670: Fix a false positive for Style/FetchEnvVar in the body with assignment method. (@ydah)
  • #10671: Fix an incorrect autocorrect for EnforcedStyle: with_first_argument of Layout/ArgumentAlignment and EnforcedColonStyle: separator of Layout/HashAlignment. (@koic)
  • #10676: Fix --ignore-unrecognized-cops option always showing empty warning even if there was no problem. (@nobuyo)
  • #10674: Fix a false positive for Naming/AccessorMethodName with type of the first argument is other than arg. (@ydah)
  • #10679: Fix a false positive for Style/SafeNavigation when TargetRubyVersion: 2.2 or lower. (@koic)

Changes

  • #10673: Update auto-gen-config's comment re auto-correct for SafeAutoCorrect: false. (@ydah)

1.30.0

New features

  • #10065: Add new Gemspec/DeprecatedAttributeAssignment cop. (@koic)
  • #10608: Add new Style/MapCompactWithConditionalBlock cop. (@nobuyo)
  • #10627: Add command-line option --ignore-unrecognized-cops to ignore any unknown cops or departments in .rubocop.yml. (@nobuyo)
  • #10620: Add Sorbet's typed sigil as a magic comment. (@zachahn)

Bug fixes

  • #10662: Recover Ruby 2.1 code analysis using TargetRubyVersion: 2.1. (@koic)
  • #10396: Fix autocorrect for Layout/IndentationWidth to leave module/class body unchanged to avoid infinite autocorrect loop with Layout/IndentationConsistency when body trails after class/module definition. (@johnny-miyake)
  • #10636: Fix false positive in Style/RedundantCondition when the branches call the same method on different receivers. (@dvandersluis)
  • #10651: Fix autocorrect for Style/For when using array with operator methods as collection. (@nobuyo)
  • #10629: Fix default Ruby version from 2.5 to 2.6. (@koic)
  • #10661: Fix a false negative for Style/SymbolProc when method has no arguments and AllowMethodsWithArguments: true. (@koic)
  • #10631: Fix autocorrect for Style/RedundantBegin. (@johnny-miyake)
  • #10652: Fix a false positive for Style/FetchEnvVar in conditions. (@ydah)
  • #10665: Fix an incorrect autocorrect for EnforcedStyle: with_first_argument of Layout/ArgumentAlignment and EnforcedColonStyle: separator of Layout/HashAlignment. (@koic)
  • #10258: Recover Ruby 2.4 code analysis using TargetRubyVersion: 2.4. (@koic)
  • #10668: Recover Ruby 2.0 code analysis using TargetRubyVersion: 2.0. (@koic)
  • #10644: Recover Ruby 2.2 code analysis using TargetRubyVersion: 2.2. (@koic)
  • #10639: Fix Style/HashSyntax to exclude files that violate it with EnforceHashShorthandSyntax when running auto-gen-config. (@nobuyo)
  • #10633: Fix infinite autocorrection loop in Style/AccessorGrouping when combining multiple of the same accessor. (@dvandersluis)
  • #10618: Fix LineBreakCorrector so that it won't remove a semicolon in the class/module body. (@johnny-miyake)
  • #10646: Fix an incorrect autocorrect for Style/SoleNestedConditional when using unless and && without parens in the outer condition and nested modifier condition. (@koic)
  • #10659: Fix automatically appended path for inherit_from by auto-gen-config is incorrect if specified config file in a subdirectory as an option. (@nobuyo)
  • #10640: Recover Ruby 2.3 code analysis using TargetRubyVersion: 2.3. (@koic)
  • #10657: Fix --auto-gen-config command option ignores specified config file by option. (@nobuyo)

Changes

  • #10095: Change "auto-correct" to "autocorrect" in arguments, documentation, messages, comments, and specs. (@chris-hewitt)
  • #10656: Mark Style/RedundantInterpolation as unsafe autocorrection. (@koic)
  • #10616: Markdown formatter: skip files with no offenses. (@rickselby)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Jul 6, 2022
@depfu depfu bot mentioned this pull request Jul 6, 2022
Closed
@mkon mkon merged commit b0c6ca0 into main Jul 19, 2022
@mkon mkon deleted the depfu/update/rubocop-1.31.1 branch July 19, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
depfu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mkon