Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade rubocop to version 1.36.0 #168

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Upgrade rubocop to version 1.36.0 #168

merged 1 commit into from
Sep 9, 2022

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Sep 9, 2022

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (1.32.0 → 1.36.0) · Repo · Changelog

Release Notes

1.36.0

New features

Bug fixes

  • #10958: Fix an infinite loop for Layout/SpaceInsideBlockBraces when EnforcedStyle is no_space and using multiline block. (@ydah)
  • #10903: Skip forking off extra processes for parallel inspection when only a single file needs to be inspected. (@wjwh)
  • #10919: Fix a huge performance regression between 1.32.0 and 1.33.0. (@ydah)
  • #10951: Fix an autocorrection error for Lint/EmptyConditionalBody when some conditional branch is empty. (@ydah)
  • #10927: Fix a false positive for Style/HashTransformKeys and Style/HashTransformValues when not using transformed block argument. (@koic)
  • #10979: Fix a false positive for Style/RedundantParentheses when using parentheses with pin operator except for variables. (@Tietew)
  • #10962: Fix a false positive for Lint/ShadowingOuterLocalVariable when conditional with if/elsif/else branches. (@ydah)
  • #10969: Fix a false negative for AllowedPatterns of Lint/AmbiguousBlockAssociation when using a method chain. (@jcalvert)
  • #10963: Fix a false positive for Layout/IndentationWidth when using aligned empty else in pattern matching. (@koic)
  • #10975: Fix possible wrong autocorrection in namespace on Style/PerlBackrefs. (@r7kamura)

Changes

  • #10928: Add more autocorrect support on Style/EachForSimpleLoop. (@r7kamura)
  • #10960: Add as to AllowedNames in default configuration for Naming/MethodParameterName cop. (@koic)
  • #10966: Add autocorrect support to Style/AccessModifierDeclarations. (@r7kamura)
  • #10940: Add server mode status to -V option. (@koic)

1.35.1

Bug fixes

  • #10926: Make Style/SafeNavigation aware of a redundant nil check. (@koic)
  • #10944: Fix an incorrect autocorrect for Lint/LiteralInInterpolation when using "#{nil}". (@koic)
  • #10921: Fix an error when ERB pre-processing of the configuration file. (@koic)
  • #10936: Fix an error for Lint/NonAtomicFileOperation when using FileTest.exist? as a condition for elsif. (@koic)
  • #10920: Fix an incorrect autocorrect for Style/SoleNestedConditional when using nested conditional and branch contains a comment. (@koic)
  • #10939: Fix an error for Style/Next when line break before condition. (@koic)

1.35.0

New features

  • #9364: Add Style/MagicCommentFormat cop. (@dvandersluis, @mattbearman)
  • #10776: New option (consistent) for EnforcedShorthandSyntax in Style/HashSyntax to avoid mixing shorthand and non-shorthand hash keys in ruby 3.1. (@h-lame)

Bug fixes

  • #10899: Fix an error for Lint/ShadowingOuterLocalVariable when the same variable name as a block variable is used in return value assignment of if. (@koic)
  • #10916: Fix an error when .rubocop.yml is empty. (@koic)
  • #10915: Fix numblock support to Layout/BlockAlignment, Layout/BlockEndNewline, Layout/EmptyLinesAroundAccessModifier, Layout/EmptyLinesAroundBlockBody, Layout/IndentationWidth, Layout/LineLength, Layout/MultilineBlockLayout, Layout/SpaceBeforeBlockBraces, Lint/NextWithoutAccumulator, Lint/NonDeterministicRequireOrder, Lint/RedundantWithIndex, Lint/RedundantWithObject, Lint/UnreachableLoop, Lint/UselessAccessModifier, Lint/Void, Metrics/AbcSize, Metrics/CyclomaticComplexity, Style/CollectionMethods, Style/CombinableLoops, Style/EachWithObject, Style/For, Style/HashEachMethods, Style/InverseMethods, Style/MethodCalledOnDoEndBlock, Style/MultilineBlockChain, Style/Next, Style/ObjectThen, Style/Proc, Style/RedundantBegin, Style/RedundantSelf, Style/RedundantSortBy and Style/TopLevelMethodDefinition. (@gsamokovarov)
  • #10895: Fix incorrect autocomplete in Style/RedundantParentheses when a heredoc is used in an array. (@dvandersluis)
  • #10909: Fix loading behavior on running without bundle exec. (@r7kamura)
  • #10913: Make Style/ArgumentsForwarding aware of anonymous block argument. (@koic)
  • #10911: Fix Style/ClassMethodsDefinitions for non-self receivers. (@sambostock)

Changes

1.34.1

Bug fixes

  • #10893: Fix an error when running rubocop without bundle exec. (@koic)

1.34.0

New features

Bug fixes

  • #10552: Require RuboCop AST 1.20.0+ to fix a false positive for Lint/OutOfRangeRegexpRef when using fixed-encoding regopt. (@koic)
  • #10512: Fix a false positive for Lint/ShadowingOuterLocalVariable conditional statement and block variable. (@ydah)
  • #10864: min and max results in false positives for Style/SymbolProc similarly to select and reject. (@mollerhoj)
  • #10846: Fix a false negative for Style/DoubleNegation when there is a hash or an array at return location of method. (@nobuyo)
  • #10875: Fix an obsolete option configuration values are duplicated when generating .rubocop_todo.yml. (@ydah)
  • #10877: Fix crash with Layout/BlockEndNewline heredoc detection. (@dvandersluis)
  • #10859: Fix Lint/Debugger to be able to handle method chains correctly. (@dvandersluis)
  • #10883: Fix Style/RedundantParentheses to be able to detect offenses and properly correct when the end parentheses and comma are on their own line. (@dvandersluis)
  • #10881: Fix Style/SoleNestedConditional to properly wrap block and csend nodes when necessary. (@dvandersluis)
  • #10867: Mark autocorrection for Lint/EmptyConditionalBody as unsafe. (@dvandersluis)
  • #10871: Restore RuboCop::ConfigLoader.project_root as deprecated. (@koic)

Changes

  • #10857: Add AllowedPatterns to Style/NumericLiterals. (@dvandersluis)
  • #10648: Allow Style/TernaryParentheses to take priority over Style/RedundantParentheses when parentheses are enforced. (@dvandersluis)
  • #10731: Show tip for suggested extensions that are installed but not loaded in .rubocop.yml. (@nobuyo)
  • #10845: Support Bundler-like namespaced feature on require config. (@r7kamura)
  • #10773: Require Parser 3.1.2.1 or higher. (@dvandersluis)

1.33.0

Bug fixes

  • #10830: Fix an incorrect autocorrect for Layout/FirstArgumentIndentation when specifying EnforcedStyle: with_fixed_indentation of Layout/ArgumentAlignment and EnforcedStyle: consistent of Layout/FirstArgumentIndentation and enabling Layout/FirstMethodArgumentLineBreak. (@koic)
  • #10825: Fix an incorrect autocorrect for Style/ClassAndModuleChildren when using nested one-liner class. (@koic)
  • #10843: Fix a false positive for Style/HashExcept when using reject and calling include? method with symbol array and second block value. (@koic)
  • #10853: Fix an autocorrect for Style/RedundantSort with logical operator. (@ydah)
  • #10842: Make server mode aware of CacheRootDirectory config option value, RUBOCOP_CACHE_ROOT, and XDG_CACHE_HOME environment variables. (@koic)
  • #10833: Fix an incorrect autocorrect for Style/RedundantCondition when branches contains arithmetic operation. (@koic)
  • #10864: Fix a false positive for Style/SymbolProc when using Hash#reject. (@koic)
  • #10771: Make server mode aware of --cache-root command line option. (@koic)
  • #10831: Fix an error when using changed_parameters in obsoletion.yml by external library. (@koic)
  • #10850: Fix Style/ClassEqualityComparison autocorrection within module. (@r7kamura)
  • #10832: Fix an incorrect autocorrect for Layout/BlockEndNewline when multiline block } is not on its own line and using heredoc argument. (@koic)

Changes

  • #10841: Don't hash shared libraries for cache key. (@ChrisBr)
  • #10862: Add autocorrection to Lint/EmptyConditionalBody. (@dvandersluis)
  • #10829: Deprecate IgnoredMethods option in favor of the AllowedMethods and AllowedPatterns options. (@ydah)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Sep 9, 2022
@depfu depfu bot mentioned this pull request Sep 9, 2022
Closed
@mkon mkon merged commit 8961259 into main Sep 9, 2022
@mkon mkon deleted the depfu/update/rubocop-1.36.0 branch September 9, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
depfu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mkon