Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rack 3.0 #171

Merged
merged 5 commits into from
Oct 5, 2022
Merged

Enable rack 3.0 #171

merged 5 commits into from
Oct 5, 2022

Conversation

mkon
Copy link
Owner

@mkon mkon commented Oct 4, 2022

Test the gem with latest rack 3.0 while remaining compatible with 2.x.

Upgrade notes:
There is some places where the "rack response array" was replaced with an instance of Rack::Response, most notably
ApiValve::Forwarder#call. To compensate this ApiValve::Proxy#call calls to_a on the result. I would recommend doing the same if you have any overrides in place, as this avoids most of the issues from a rack 3 upgrade.

@mkon mkon force-pushed the rack-3.0 branch 3 times, most recently from 064033e to 581601d Compare October 4, 2022 19:44
@mkon mkon changed the title Test for rack 3.0 Enable rack 3.0 Oct 4, 2022
@mkon mkon force-pushed the rack-3.0 branch 3 times, most recently from e02797a to ba90486 Compare October 5, 2022 08:25
@mkon mkon merged commit ddcff9d into main Oct 5, 2022
@mkon mkon deleted the rack-3.0 branch October 5, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant