Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop → 1.57.2 (unknown) #188

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Nov 2, 2023

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (1.56.4 → 1.57.2) · Repo · Changelog

Release Notes

1.57.2

Bug fixes

  • #12274: Fix a false positive for Lint/Void when each's receiver is an object of Enumerator to which filter has been applied. (@koic)
  • #12291: Fix a false positive for Metrics/ClassLength when a class with a singleton class definition. (@koic)
  • #12293: Fix a false positive for Style/RedundantDoubleSplatHashBraces when using double splat hash braces with merge and method chain. (@koic)
  • #12298: Fix a false positive for Style/RedundantParentheses when using a parenthesized hash literal as the first argument in a method call without parentheses. (@koic)
  • #12283: Fix an error for Style/SingleLineDoEndBlock when using single line do...end with no body. (@koic)
  • #12312: Fix an incorrect autocorrect for Style/HashSyntax when braced hash key and value are the same and it is used in if...else. (@koic)
  • #12307: Fix an infinite loop error for Layout/EndAlignment when EnforcedStyleAlignWith: variable and using a conditional statement in a method argument on the same line and end with method call is not aligned. (@koic)
  • #11652: Make --auto-gen-config generate inherit_from correctly inside ERB if. (@jonas054)
  • #12310: Drop base64 gem from runtime dependency. (@koic)
  • #12300: Fix an error for Style/IdenticalConditionalBranches when if...else with identical leading lines and using index assign. (@koic)
  • #12286: Fix false positives for Style/RedundantDoubleSplatHashBraces when using double splat with a hash literal enclosed in parenthesized ternary operator. (@koic)
  • #12279: Fix false positives for Lint/EmptyConditionalBody when missing 2nd if body with a comment. (@koic)
  • #12275: Fix a false positive for Style/RedundantDoubleSplatHashBraces when using double splat within block argument containing a hash literal in an array literal. (@koic)
  • #12284: Fix false positives for Style/SingleArgumentDig when using some anonymous argument syntax. (@koic)
  • #12301: Make Style/RedundantFilterChain aware of safe navigation operator. (@koic)

1.57.1

Bug fixes

  • #12271: Fix a false positive for Lint/RedundantSafeNavigation when using snake case constant receiver. (@koic)
  • #12265: Fix an error for Layout/MultilineMethodCallIndentation when usingarithmetic operation with block inside a grouped expression. (@koic)
  • #12177: Fix an incorrect autocorrect for Style/RedundantException. (@ydah)
  • #12261: Fix an infinite loop for Layout/MultilineMethodCallIndentation when multiline method chain with a block argument and method chain. (@ydah)
  • #12263: Fix false positives for Style/RedundantDoubleSplatHashBraces when method call for no hash braced double splat receiver. (@koic)
  • #12262: Fix an incorrect autocorrect for Style/RedundantDoubleSplatHashBraces when using double splat hash braces with merge method call twice. (@koic)

1.57.0

New features

  • #12227: Add new Style/SingleLineDoEndBlock cop. (@koic)
  • #12246: Make Lint/RedundantSafeNavigation aware of constant receiver. (@koic)
  • #12257: Make Style/RedundantDoubleSplatHashBraces aware of merge methods. (@koic)

Bug fixes

  • #12244: Fix a false negative for Lint/Debugger when using debugger method inside block. (@koic)
  • #12231: Fix a false negative for Metrics/ModuleLength when defining a singleton class in a module. (@koic)
  • #12249: Fix a false positive Style/IdenticalConditionalBranches when if..else with identical leading lines and assign to condition value. (@koic)
  • #12253: Fix Lint/LiteralInInterpolation to accept an empty string literal interpolated in words literal. (@knu)
  • #12198: Fix an error for flip-flop with beginless or endless ranges. (@koic)
  • #12259: Fix an error for Lint/MixedCaseRange when using nested character class in regexp. (@koic)
  • #12237: Fix an error for Style/NestedTernaryOperator when a ternary operator has a nested ternary operator within an if. (@koic)
  • #12228: Fix false negatives for Style/MultilineBlockChain when using multiline block chain with safe navigation operator. (@koic)
  • #12247: Fix false negatives for Style/RedundantParentheses when using logical or comparison expressions with redundant parentheses. (@koic)
  • #12226: Fix false positives for Layout/MultilineMethodCallIndentation when aligning methods in multiline block chain. (@koic)
  • #12076: Fixed an issue where the top-level cache folder was named differently during two consecutive rubocop runs. (@K-S-A)

Changes

  • #12235: Enable auto parallel inspection when config file is specified. (@aboutNisblee)
  • #12234: Enhance Style/FormatString's autocorrection when using known conversion methods whose return value is not an array. (@koic)
  • #12128: Make Style/GuardClause aware of define_method. (@koic)
  • #12126: Make Style/RedundantFilterChain aware of select.present? when ActiveSupportExtensionsEnabled config is true. (@koic)
  • #12250: Mark Lint/RedundantRequireStatement as unsafe autocorrect. (@koic)
  • #12097: Mark unsafe autocorrect for Style/ClassEqualityComparison. (@koic)
  • #12210: Mark Style/RedundantFilterChain as unsafe autocorrect. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Nov 2, 2023
@mkon mkon merged commit c51ff77 into main Nov 2, 2023
4 checks passed
@mkon mkon deleted the depfu/update/rubocop-1.57.2 branch November 2, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant