Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of rubocop-rspec (2.16.0) produced dependency conflicts #151

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Dec 20, 2022

👉 This PR is queued up to get rebased by Depfu

We've tried to upgrade a dependency and got errors running Bundler. It looks like there is a version conflict between two or more dependencies. Depfu doesn't try to solve these, as this would mean to update more than one dependency at a time.

Please take a look at the exact failure to figure out if this is something you need to work on.

The bundler error message was:

Bundler could not find compatible versions for gem "rubocop":
  In Gemfile:
    rubocop (= 1.31.1)

    rubocop-rspec (= 2.16.0) was resolved to 2.16.0, which depends on
      rubocop (~> 1.33)

What changed?

✳️ rubocop-rspec (2.12.1 → 2.16.0) · Repo · Changelog

Release Notes

2.16.0

  • Add new RSpec/FactoryBot/FactoryNameStyle cop. (@ydah)
  • Improved processing speed for RSpec/Be, RSpec/ExpectActual, RSpec/ImplicitExpect, RSpec/MessageSpies, RSpec/PredicateMatcher and RSpec/Rails/HaveHttpStatus. (@ydah)
  • Fix wrong autocorrection in n_times style on RSpec/FactoryBot/CreateList. (@r7kamura)
  • Fix a false positive for RSpec/FactoryBot/ConsistentParenthesesStyle when using generate with multiple arguments. (@ydah)
  • Mark RSpec/BeEq as Safe: false (@r7kamura)
  • Add RSpec/DuplicatedMetadata cop. (@r7kamura)
  • Mark RSpec/BeEql as Safe: false. (@r7kamura)
  • Add RSpec/PendingWithoutReason cop. (@r7kamura)

2.15.0

  • Fix a false positive for RSpec/RepeatedDescription when different its block expectations are used. (@ydah)
  • Add named_only style to RSpec/NamedSubject. (@kuahyeow)
  • Fix RSpec/FactoryBot/ConsistentParenthesesStyle to ignore calls without the first positional argument. (@pirj)
  • Fix RSpec/FactoryBot/ConsistentParenthesesStyle to ignore calls inside a Hash or an Array. (@pirj)
  • Fix RSpec/NestedGroups to correctly use AllowedGroups config. (@samrjenkins)
  • Remove Runners and HookScopes RSpec DSL elements from configuration. (@pirj)
  • Add with default RSpec/Language config helper to lib (under rubocop/rspec/shared_contexts/default_rspec_language_config_context), to allow use for downstream cops based on RuboCop::Cop::RSpec::Base. (@smcgivern)

2.14.2

  • Fix an incorrect autocorrect for FactoryBot/ConsistentParenthesesStyle with omit_parentheses option when method name and first argument are not on same line. (@ydah)
  • Fix autocorrection loop in RSpec/ExampleWording for insufficient example wording. (@pirj)
  • Fix RSpec/SortMetadata not to reorder arguments of include_/it_behaves_like. (@pirj)
  • Fix a false positive for RSpec/NoExpectationExample when allowed pattern methods with arguments. (@ydah)
  • Change RSpec/FilePath so that it only checks suffix when path is under spec/routing or type is defined as routing. (@r7kamura)

2.14.1

  • Fix an error for RSpec/Rails/InferredSpecType with redundant type before other Hash metadata. (@ydah)

2.14.0

  • Add require_implicit style to RSpec/ImplicitSubject. (@r7kamura)
  • Fix a false positive for RSpec/Capybara/SpecificMatcher when have_css("a") without attribute. (@ydah)
  • Update RSpec/ExampleWording cop to raise error for insufficient descriptions. (@akrox58)
  • Add new RSpec/Capybara/NegationMatcher cop. (@ydah)
  • Add AllowedPatterns configuration option to RSpec/NoExpectationExample. (@ydah)
  • Improve RSpec/NoExpectationExample cop to ignore examples skipped or pending via metadata. (@pirj)
  • Add RSpec/FactoryBot/ConsistentParenthesesStyle cop. (@Liberatys)
  • Add RSpec/Rails/InferredSpecType cop. (@r7kamura)
  • Add new RSpec/Capybara/SpecificActions cop. (@ydah)
  • Update config/default.yml removing deprecated option to make the config correctable by users. (@ignaciovillaverde)
  • Do not attempt to auto-correct example groups with include_examples in RSpec/LetBeforeExamples. (@pirj)
  • Add new RSpec/SortMetadata cop. (@leoarnold)
  • Add support for subject! method to RSpec/SubjectDeclaration. (@ydah)

2.13.2

  • Fix an error for RSpec/Capybara/SpecificFinders with no parentheses. (@ydah)
  • Fix a false positive for RSpec/NoExpectationExample with pending using skip or pending inside an example. (@ydah)
  • Exclude have_text and have_content that raise ArgumentError with RSpec/Capybara/VisibilityMatcher where :visible is an invalid option. (@ydah)
  • Fix a false negative for RSpec/Capybara/VisibilityMatcher with negative matchers. (@ydah)

2.13.1

Include config/obsoletion.yml in the gemspec. (@hosamaly)

2.13.0

  • Fix RSpec/FilePath cop missing mismatched expanded namespace. (@sl4vr)
  • Add new AllowConsecutiveOneLiners (default true) option for Rspec/EmptyLineAfterHook cop. (@ngouy)
  • Add autocorrect support for RSpec/EmptyExampleGroup. (@r7kamura)
  • Fix RSpec/ChangeByZero with compound expressions using & or | operators. (@BrianHawley)
  • Add RSpec/NoExpectationExample. (@r7kamura)
  • Add some expectation methods to default configuration. (@r7kamura)
  • Fix a false positive for RSpec/Capybara/SpecificMatcher. (@ydah)
  • Fix a false negative for RSpec/Capybara/SpecificMatcher for have_field. (@ydah)
  • Fix a false positive for RSpec/Capybara/SpecificMatcher when may not have a href by have_link. (@ydah)
  • Add NegatedMatcher configuration option to RSpec/ChangeByZero. (@ydah)
  • Add new RSpec/Capybara/SpecificFinders cop. (@ydah)
  • Add support for numblocks to RSpec/AroundBlock, RSpec/EmptyLineAfterHook, RSpec/ExpectInHook, RSpec/HookArgument, RSpec/HooksBeforeExamples, RSpec/IteratedExpectation, and RSpec/NoExpectationExample. (@ydah)
  • Fix incorrect documentation URLs when using rubocop --show-docs-url. (@r7kamura)
  • Add AllowedGroups configuration option to RSpec/NestedGroups. (@ydah)
  • Deprecate IgnoredPatterns option in favor of the AllowedPatterns options. (@ydah)
  • Add AllowedPatterns configuration option to RSpec/ContextWording. (@ydah)
  • Add RSpec/ClassCheck cop. (@r7kamura)
  • Fix a false positive for RSpec/Capybara/SpecificMatcher when pseudo-classes. (@ydah)
  • Fix a false negative for RSpec/SubjectStub when the subject is declared with the subject! method and called by name. (@eikes)
  • Support Array.new(n) on RSpec/FactoryBot/CreateList cop. (@r7kamura)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@mkon
Copy link
Owner

mkon commented Jan 19, 2023

@depfu rebase

@depfu depfu bot force-pushed the depfu/update/rubocop-rspec-2.16.0 branch from fa2259f to 4086b43 Compare January 19, 2023 21:55
@mkon mkon merged commit fe87634 into main Jan 20, 2023
@mkon mkon deleted the depfu/update/rubocop-rspec-2.16.0 branch January 20, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant