Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rubocop-rspec to version 2.18.1 #153

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Jan 23, 2023

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (2.16.0 → 2.18.1) · Repo · Changelog

Release Notes

2.18.1

  • Add rubocop-capybara version constraint to prevent sudden cop enabling when it hits 3.0. (@pirj)

2.18.0

  • Extract Capybara cops to a separate repository, rubocop-capybara. The rubocop-capybara repository is a dependency of rubocop-rspec and the Capybara cops are aliased (RSpec/Capybara/Foo == Capybara/Foo) until v3.0 is released, so the change will be invisible to users until then. (@pirj)

2.17.1

  • Fix a false negative for RSpec/Pending when using skipped in metadata is multiline string. (@ydah)
  • Fix a false positive for RSpec/NoExpectationExample when using skipped in metadata is multiline string. (@ydah)
  • Fix a false positive for RSpec/ContextMethod when multi-line context with # at the beginning. (@ydah)
  • Fix an incorrect autocorrect for RSpec/PredicateMatcher when multiline expect and predicate method with heredoc. (@ydah)
  • Fix a false positive for RSpec/PredicateMatcher when include with multiple argument. (@ydah)

2.17.0

  • Fix a false positive for RSpec/PendingWithoutReason when pending/skip is argument of methods. (@ydah)
  • Add new RSpec/Capybara/MatchStyle cop. (@ydah)
  • Add new RSpec/Rails/MinitestAssertions cop. (@ydah)
  • Fix a false positive for RSpec/PendingWithoutReason when not inside example. (@ydah)
  • Fix a false negative for RSpec/PredicateMatcher when using include and respond_to. (@ydah)
  • Fix a false positive for RSpec/StubbedMock when stubbed message expectation with a block and block parameter. (@ydah)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 71 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Jan 23, 2023
@mkon mkon merged commit abce003 into main Jan 24, 2023
@mkon mkon deleted the depfu/update/rubocop-rspec-2.18.1 branch January 24, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant