Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade rubocop to version 1.44.1 #154

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Upgrade rubocop to version 1.44.1 #154

merged 1 commit into from
Feb 10, 2023

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Feb 1, 2023

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (1.42.0 → 1.44.1) · Repo · Changelog

Release Notes

1.44.1

Bug fixes

  • #11492: Fix an error for Lint/Void when configuring CheckForMethodsWithNoSideEffects: true. (@koic)
  • #11400: Fix an incorrect autocorrect for Naming/BlockForwarding and Lint/AmbiguousOperator when autocorrection conflicts for ambiguous splat argument. (@fatkodima)
  • #11483: Fix Layout/ClosingParenthesisIndentation for keyword splat arguments. (@fatkodima)
  • #11487: Fix a false positive for Lint/FormatParameterMismatch when format string is only interpolated string. (@ydah)
  • #11485: Fix a false positive for Lint/UselessAssignment when using numbered block parameter. (@koic)

1.44.0

New features

  • #11410: Add new Style/InvertibleUnlessCondition cop. (@fatkodima)
  • #11338: Add new Style/ComparableClamp cop. (@koic)
  • #11350: Make Lint/DeprecatedClassMethods aware of deprecated attr with boolean 2nd argument. (@koic)
  • #11457: Make Metrics/BlockNesting aware of pattern matching. (@koic)
  • #11458: Make Metrics/CyclomaticComplexity aware of pattern matching. (@koic)
  • #11469: Add Gemspec/DevelopmentDependencies cop. (@sambostock)

Bug fixes

  • #11445: Fix an incorrect autocorrect for Style/BlockDelimiters when there is a comment after the closing brace and bracket. (@koic)
  • #11428: Apply value omission exceptions in super invocations. (@gsamokovarov)
  • #11420: Fix a false positive for Lint/UselessRescue when using exception variable in ensure clause. (@koic)
  • #11460: Fix an error for Style/OperatorMethodCall when using foo.> 42. (@koic)
  • #11456: Fix value omissions in yield invocations. (@gsamokovarov)
  • #11467: Fix a false negative for Style/MethodCallWithoutArgsParentheses when calling method on a receiver and assigning to a variable with the same name. (@koic)
  • #11430: Fix an infinite loop error for Layout/BlockEndNewline when multiline blocks with newlines before the ; end. (@koic)
  • #11442: Fix a crash during anonymous rest argument forwarding. (@gsamokovarov)
  • #11447: Fix an incorrect autocorrect for Style/RedundantDoubleSplatHashBraces when using nested double splat hash braces. (@koic)
  • #11459: Make Lint/UselessRuby2Keywords aware of conditions. (@splattael)
  • #11415: Fix a false positive for Lint/UselessMethodDefinition when method definition contains rest arguments. (@koic)
  • #11418: Fix a false positive for Style/MethodCallWithArgsParentheses when using anonymous rest arguments or anonymous keyword rest arguments. (@koic)
  • #11431: Fix a crash in Style/HashSyntax. (@gsamokovarov)
  • #11444: Fix a false positive for Lint/ShadowingOuterLocalVariable when using numbered block parameter. (@koic)
  • #11477: Fix an error when using YAML alias with server mode. (@koic)
  • #11419: Fix a false positive for Style/RedundantRequireStatement when using pretty_inspect. (@koic)
  • #11439: Fix an incorrect autocorrect for Style/MinMaxComparison when using a < b a : b with elsif/else. (@ydah)
  • #11464: Fix a false negative for Lint/FormatParameterMismatch when include interpolated string. (@ydah)
  • #11425: Fix a false negative for Lint/Void when using methods that takes blocks. (@krishanbhasin-shopify)
  • #11437: Fix an error for Style/AccessModifierDeclarations when access modifier is inlined with a method on the top level. (@koic)
  • #11455: Fix crash with super value_omission: followed by a method call. (@gsamokovarov)

Changes

  • #11465: Make Style/Semicolon aware of redundant semicolon in block. (@koic)
  • #11471: Change to not output not configured warning when renamed and pending cop. (@ydah)

1.43.0

New features

Bug fixes

  • #11386: Fix a false positive for Style/OperatorMethodCall when using anonymous forwarding. (@koic)
  • #11409: Fix an incorrect autocorrect for Style/HashSyntax when using hash value omission and EnforcedStyle: no_mixed_keys. (@koic)
  • #11405: Fix undefined method `range_between' for Style/WhileUntilModifier. (@such)
  • #11374: Fix an error for Style/StringHashKeys when using invalid symbol in encoding UTF-8 as keys. (@koic)
  • #11392: Fix an incorrect autocorrect for Style/RedundantDoubleSplatHashBraces using double splat in double splat hash braces. (@koic)
  • #8990: Make Style/HashEachMethods aware of built-in Thread.current. (@koic)
  • #11390: Fix an incorrect autocorrect for Style/HashSyntax when hash first argument key and hash value only are the same which has a method call on the next line. (@koic)
  • #11379: Fix a false negative for Style/OperatorMethodCall when using a.+ b.something. (@koic)
  • #11180: Fix an error for Style/RedundantRegexpEscape when using %r to provide regexp expressions. (@si-lens)
  • #11403: Fix bad offense for parenthesised calls in literals for omit_parentheses style in Style/MethodCallWithArgsParentheses. (@gsamokovarov)
  • #11407: Fix an error for Style/HashSyntax when expression follows hash key assignment. (@fatkodima)
  • #11377: Fix Style/OperatorMethodCall when forwarding arguments. (@sambostock)

Changes

  • #11382: Require unicode-display_width 2.4.0 or higher. (@fatkodima)
  • #11381: Require Parser 3.2.0.0 or higher. (@koic)
  • #11380: Disable Style/YodaExpression by default. (@koic)
  • #11303: Make Metrics/ParameterLists aware of Struct.new and Data.define blocks. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Feb 1, 2023
@mkon mkon merged commit ba755c0 into main Feb 10, 2023
@mkon mkon deleted the depfu/update/rubocop-1.44.1 branch February 10, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
depfu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mkon