Upgrade rubocop to version 1.36.0 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![depfu[bot]](https://avatars.githubusercontent.com/in/715?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (1.35.0 → 1.36.0) · Repo · Changelog
Release Notes
1.36.0
1.35.1
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 74 commits:
Cut 1.36Update ChangelogAdd a spec for server modeMerge pull request #10984 from r7kamura/feature/modifier-exampleImprove singleton method example on `Lint/UselessAccessModifier` copFix an error for `rake prof:slow_cops`Merge pull request #10928 from r7kamura/feature/eachMerge pull request #10981 from Tietew/fix_a_false_positive_for_style_redundant_parenthesesMerge pull request #10932 from koic/use_official_jruby_image[Fix #10979] Fix a false positive for `Style/Style/RedundantParentheses`Use GitHub Actions instead of CircleCI for JRuby matrixAdd more autocorrect support on `Style/EachForSimpleLoop`Merge pull request #10970 from jcalvert/fix/10969[Fix rubocop#10969] Allow `Lint/AmbiguousBlockAssociation` `AllowedPattern` to match onAdd `AllowOnSelfClass` option to `Style/CaseEquality`Do not fork off extra processes if only a single file needs inspectionFix possible wrong autocorrection in namespace on `Style/PerlBackrefs`Improve safety section on `Style/SymbolProc`Merge pull request #10973 from r7kamura/feature/strongMerge pull request #10972 from r7kamura/feature/asciidoc-backtickFix wrong asterisk use in `Lint/UselessRuby2Keywords` documentFix some broken codes in Asciidoc documentsMerge pull request #10952 from ydah/fix/empty_conditional_bodyMerge pull request #10968 from ydah/fix/10962[Fix #10962] Fix a false positive for `Lint/ShadowingOuterLocalVariable` when conditional with if/elsif/else branches[Fix #10951] Fix an autocorrection error for `Lint/EmptyConditionalBody` when some conditional branch is emptyMerge pull request #10966 from r7kamura/feature/modifier-autocorrectMerge pull request #10953 from ydah/speed_improvementMerge pull request #10964 from koic/fix_a_false_positive_for_layout_indentation_widthMerge pull request #10959 from ydah/fix_space_inside_block_braces[Fix #10958] Fix an infinite loop for `Layout/SpaceInsideBlockBraces` when `EnforcedStyle` is `no_space` and using multiline blockMerge pull request #10967 from MSP-Greg/00-actions-no-colorAdd autocorrect support to `Style/AccessModifierDeclarations`Actions - use --no-colorMerge pull request #10965 from MSP-Greg/00-windowsActions - add workflow_dispatch for use in forks.gitignore - add vendor/ for local developmentformatter/formatter_set_spec.rb - remove references to file IO on Windows[Fix #10963] Fix a false positive for `Layout/IndentationWidth`[Fix #10919] Fix a huge performance regression between 1.32.0 and 1.33.0Merge pull request #10955 from koic/fix_a_flaky_test_of_formatter_set_specWorkaround for mingw build error[Fix #10960] Add `as` to `AllowedNames` of `Naming/MethodParameterName` copTweak the doc of server modeMerge pull request #10950 from ydah/doc/block_alignment[Fix #10949] Fix documentation error for `Layout/BlockAlignment`[Fix #10927] Fix a false positive for `Style/HashTransformKeys` and `Style/HashTransformValues`Add server mode status to `-V` optionSwitch back the docs versionCut 1.35.1Update Changelog[Fix #10939] Fix an error for `Style/Next`Merge pull request #10945 from koic/fix_an_incorrect_autocorrect_for_lint_literal_in_interpolationMerge pull request #10946 from fatkodima/safe-navigation-negatedFix `Style/SafeNavigation` for negated method call with a safe navigation[Fix #10944] Fix an incorrect autocorrect for `Lint/LiteralInInterpolation`Make `InternalAffairs/SingleLineComparison` aware of negative comparisonMerge pull request #10941 from fatkodima/fix-prof-slow_copsFix `rake prof:slow_cops` to return correct resultsEnhanced documentation for `Lint/RedundantSafeNavigation`Enhanced documentation for `Style/GuardClause`Fix some typos[Fix #10921] Fix an error when processing configuration file[Fix #10926] Make `Style/SafeNavigation` aware of a redundant nil check[Fix #10936] Fix an error for `Lint/NonAtomicFileOperation`Merge pull request #10935 from ydah/fix/filenameCorrect the typo in the filenameFix trivial typoFix typosFix an incompatibility error when nested `LoadError`Merge pull request #10923 from koic/fix_an_incorrect_autocorrect_for_style_sole_nested_conditional[Fix #10920] Fix an incorrect autocorrect for `Style/SoleNestedConditional`Find Gemfile.lock before gems.lockedSwitch back docs versionDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands