Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rubocop to version 1.39.0 #25

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Nov 21, 2022

👉 This PR is queued up to get rebased by Depfu

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (1.37.1 → 1.39.0) · Repo · Changelog

Release Notes

1.39.0

New features

Bug fixes

  • #11150: Improve Style/RedundantRegexpEscape to catch unnecessarily escaped hyphens within a character class. (@si-lens)
  • #11168: Fix an incorrect autocorrect for Style/ClassEqualityComparison when using instance variable comparison in module. (@koic)
  • #11176: Fix a false positive cases for Lint/DuplicateMethods when using duplicate nested method. (@koic)
  • #11164: Suppress "RuboCop server starting..." message with --server --format json. (@koic)
  • #11156: Fix Style/OperatorMethodCall autocorrection when operators are chained. (@gsamokovarov)
  • #11139: Fix a false negative for Style/HashEachMethods when using each with a symbol proc argument. (@ydah)
  • #11161: Fix a false positive for Style/HashAsLastArrayItem when using double splat operator. (@koic)
  • #11151: Fix a false positive for Lint/SuppressedException. (@akihikodaki)
  • #11123: Fix autocorrection bug for Style/StringLiterals when using multiple escape characters. (@si-lens)
  • #11165: Fix a false positive for Style/RedundantEach when any method is used between methods containing each in the method name. (@koic)
  • #11177: Fix a false positive for Style/ObjectThen cop with TargetRubyVersion < 2.6. (@epaew)
  • #11173: Fix an incorrect autocorrect for Style/CollectionCompact when using reject with block pass arg and no parentheses. (@koic)
  • #11137: Fix a false positive for Style/RedundantEach when using a symbol proc argument. (@ydah)
  • #11142: Fix Style/RedundantEach for non-chained each_ calls. (@fatkodima)

Changes

1.38.0

New features

Bug fixes

  • #11125: Fix an error for Layout/SpaceInsideHashLiteralBraces when using method argument that both key and value are hash literals. (@koic)
  • #11132: Fix clobbering error on Lint/EmptyConditionalBody. (@r7kamura)
  • #11117: Fix a false positive for Style/BlockDelimiters when specifying EnforcedStyle: semantic and using a single line block with {} followed by a safe navigation method call. (@koic)
  • #11120: Fix an incorrect autocorrect for Lint/RedundantRequireStatement when using redundant require with modifier form. (@koic)

Changes

  • #11131: Check newline in empty reference bracket on Layout/SpaceInsideReferenceBrackets. (@r7kamura)
  • #11045: Update the Style/ModuleFunction documentation to suggest class << self as an alternative. (@rdeckard)
  • #11006: Allow multiple elsif for Style/IfWithBooleanLiteralBranches. (@koic)
  • #11113: Report the count of files in the Worst and the Offense Count formatters. (@hosamaly)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 66 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Nov 21, 2022
@depfu depfu bot force-pushed the depfu/update/rubocop-1.39.0 branch from 1ceaa5a to 2d47145 Compare November 23, 2022 08:45
@mkon mkon merged commit 78c2e95 into main Nov 23, 2022
@mkon mkon deleted the depfu/update/rubocop-1.39.0 branch November 23, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant