Upgrade rubocop to version 1.40.0 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![depfu[bot]](https://avatars.githubusercontent.com/in/715?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (1.39.0 → 1.40.0) · Repo · Changelog
Release Notes
1.40.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 69 commits:
Cut 1.40Update ChangelogOptimize checking if the file is relevant for the copMerge pull request #11248 from ydah/fix/typosFix a typo for CHANGELOG entryMerge pull request #11245 from ydah/fix/11244[Fix #11244] Fix a false negative for `Style/RedundantReturn` when dynamic define methods[Fix #11239] Fix an incorrect autocorrect for `Style/GuardClause`Update examples and docUpdate exampleAdd new `Style/ArrayIntersect` copAdd `Style/RequireOrder` copMerge pull request #11240 from fatkodima/optimizeOptimize rubocopUse Ruby 3.2 parser for docs[CI] Add GitHub token permissions for workflows (#10947)[Fix #11213] Support redundant department disable lintingRemove `respond_to` from default value of `AllowedMethods` for `Style/SymbolProc`Add ability to count method calls as one line to code length related `Metric` cops[Fix #5251] Fix loading of configuration in multi-file edge case[Fix #11230] Fix an incorrect autocorrect for `Lint/SafeNavigationChain`Handle ternaries in `Style/SafeNavigation`Add `Style/RedundantConstantBase` cop (#11179)Merge pull request #11234 from rubocop/ci-setupCI: Let ruby/setup-run install gemsMerge pull request #11229 from tjschuck/allow-cc-as-2-letter-method-nameAdd `cc` to `AllowedNames` of `MethodParameterName` copMake `Lint/Void` aware of used lambda and proc[Fix #11219] Make `Style/SelectByRegexp` aware of `!~` methodAdd `--[no-]auto-gen-enforced-style` CLI optionUpdate severity of some `Bundler` and `RubyGems` cops to warningMake `Style/RedundantArgument` aware of `Array#sum`Add new `InternalAffairs/LambdaOrProc` copMerge pull request #11217 from rubocop/dependabot/github_actions/actions/setup-python-4Bump actions/setup-python from 2 to 4Added dependabot for GitHub ActionsUpdate lib/rubocop/cop/lint/assignment_in_condition.rbAdd autocorrect for `Lint/AssignmentInCondition`Change `Lint/InterpolationCheck` from `Safe: false` to `SafeAutoCorrect: false`Remove a redundant conditionMake `Lint/DeprecatedConstants` aware of `Struct::Group` and `Struct::Passwd`[Fix #11143] RedundantCopDisableDirective ignores departments (#11210)Merge pull request #11209 from DiegoSPB/fix-11157[fix rubocop#11157] -- Update Registry Docs[Doc] Update the configuration.adocMerge pull request #11201 from koic/fix_an_incorrect_autocorrect_for_layout_multiline_method_call_brace_layoutMerge pull request #11203 from r7kamura/feature/send-with-mixinSupport multiple arguments on `Lint/SendWithMixinArgument`[Fix #11200] Fix an incorrect autocorrect for `Layout/MultilineMethodCallBraceLayout`Merge pull request #11198 from koic/fix_error_for_lint_empty_conditional_bodyFix an error for `Lint/EmptyConditionalBody`Fix a build error[Fix #11182] Fix an incorrect autocorrect for `Style/IfUnlessModifier`Make `Style/HashSyntax` aware of without parentheses call expr follows[Fix #11196] Fix a false positive for `Style/GuardClause`Merge pull request #11194 from ydah/fix/11192[Fix #11192] Fix a false positive for `Lint/ParenthesesAsGroupedExpression` when using a block argumentFix a typoFix a typoMerge pull request #11190 from koic/fix_an_error_for_style_if_with_semicolonFix an error for `Style/IfWithSemicolon`Merge pull request #11186 from koic/fix_error_for_lint_shadowing_outer_local_variable[Doc] Update an internal API comment[Doc] Tweak the doc for `Lint/DeprecatedConstants`[Fix #11184] Fix an error for `Lint/ShadowingOuterLocalVariable`Merge pull request #11181 from noelblaschke/fix/asdf-tool-versions-may-contain-multiple-runtimesFix pattern to match .tool-versions files that specify multiple runtimesFix a duplication in the changelogSwitch back the docs versionDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands