Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different filenames for API contracts #33

Merged
merged 2 commits into from
Feb 11, 2023

Conversation

dveljacic
Copy link
Contributor

@dveljacic dveljacic commented Feb 9, 2023

Hi @mkon,

what do you think about this feature that I've tried to implement?

I found your gem useful, but it would be great if it could use different filenames for contracts, instead of just openapi.yaml that was previously hard-coded, especially in cases where there are different versions of the API specs (contracts).

For backward-compatibility reasons, I've set the default filename to openapi.yaml, but left the possibility for the user to define the name as a second argument.

Hoping to hear your feedback and maybe contribute here.

@mkon
Copy link
Owner

mkon commented Feb 10, 2023

Hi @dveljacic!

Thanks for the contribution, looks good to me. Let's see if it's green then we are good to go.

@mkon mkon merged commit 61f0d2e into mkon:main Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants