Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade rubocop to version 1.48.1 #36

Merged
merged 1 commit into from
Mar 18, 2023
Merged

Upgrade rubocop to version 1.48.1 #36

merged 1 commit into from
Mar 18, 2023

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Mar 17, 2023 •
edited
Loading

👉 This PR is queued up to get rebased by Depfu

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (1.45.1 → 1.48.1) · Repo · Changelog

Release Notes

1.48.1

Bug fixes

  • #11673: Fix incorrect Style/HashSyntax autocorrection for assignment methods. (@gsamokovarov)
  • #11682: Fix a false positive for Lint/UselessRescue when using Thread#raise in rescue clause. (@koic)
  • #11672: Fix an error for Layout/BlockEndNewline when multiline block } is not on its own line and it is used as multiple arguments. (@koic)
  • #11675: Style/AccessorGrouping: Fix sibling detection for methods with type sigs. (@issyl0)
  • #11658: Fix Lint/Debugger should not allow pry. (@ThHareau)
  • #11686: Fix Lint/Syntax behavior when Enabled: false of Lint department. (@koic)
  • #11677: Fix the severity for Lint/Syntax. (@koic)
  • #11691: Fix an error for Gemspec/DependencyVersion when method called on gem name argument for add_dependency. (@koic)

1.48.0

New features

Bug fixes

  • #11654: Fix a false positive for Lint/MissingSuper when no super call and when defining some method. (@koic)
  • #11661: Fix an error for Style/Documentation when namespace is a variable. (@koic)
  • #11647: Fix an error for Style/IfWithBooleanLiteralBranches when using () as a condition. (@koic)
  • #11646: Fix an error for Style/NegatedIfElseCondition when using () as a condition. (@koic)
  • #11659: Fix an incorrect autocorrect for Lint/OrAssignmentToConstant when using or-assignment to a constant in method definition. (@koic)
  • #11663: Fix an incorrect autocorrect for Style/BlockDelimiters when multi-line blocks to { and } with arithmetic operation method chain. (@koic)
  • #11638: Fix a false positive for Lint/UselessAccessModifier when using same access modifier inside and outside the included block. (@ydah)
  • #11164: Suppress server mode message with -f json. (@jasondoc3)
  • #11643: Fix incorrect shorthand autocorrections in calls inside parentheses. (@gsamokovarov)
  • #11650: Style/AccessorGrouping: Fix detection of Sorbet sig {} blocks. (@issyl0)
  • #11657: Use cop name to check if cop inside registry is enabled. Previously, it was able to cause large memory usage during linting. (@fatkodima)

Changes

  • #11482: Avoid comment deletion by Style/IfUnlessModifier when the modifier form expression has long comment. (@nobuyo)
  • #11649: Support MinBranchesCount config for Style/CaseLikeIf cop. (@fatkodima)

1.47.0

New features

Bug fixes

  • #11615: Fix a false negative for Lint/MissingSuper when no super call with Class.new block. (@koic)
  • #11615: Fix a false negative for Lint/MissingSuper when using Class.new without parent class argument. (@koic)
  • #11040: Fix a false positive for Style/IfUnlessModifier when defined?'s argument value is undefined. (@koic)
  • #11607: Fix a false positive for Style/RedundantRegexpEscape when an escaped hyphen follows after an escaped opening square bracket within a character class. (@SparLaimor)
  • #11626: Fix a false positive for Style/ZeroLengthPredicate when using File.new(path).size.zero?. (@koic)
  • #11620: Fix an error for Lint/ConstantResolution when using __ENCODING__. (@koic)
  • #11625: Fix an error for Lint/EmptyConditionalBody when missing if body and using method call for return value. (@koic)
  • #11631: Fix an incorrect autocorrect for Style/ArgumentsForwarding when using arguments forwarding for .() call. (@koic)
  • #11621: Fix an incorrect autocorrect for Layout/ClassStructure using heredoc inside method. (@fatkodima)
  • #3591: Handle modifier while and until expressions in Lint/UselessAssignment. (@bfad)
  • #11202: Fixed usage of --only flag with --auto-gen-config. (@istvanfazakas)

Changes

  • #11623: Add rubocop-capybara to suggested extensions and extension doc. (@ydah)

1.46.0

New features

  • #11569: Support TargetRubyVersion 3.3 (experimental). (@koic)

Bug fixes

  • #11574: Fix a broken shorthand syntax autocorrection. (@gsamokovarov)
  • #11599: Fix a false positive for Layout/LineContinuationSpacing when using percent literals. (@koic)
  • #11556: Fix a false positive for Lint/Debugger when p is an argument of method call. (@koic)
  • #11591: Fix a false positive for Lint/ToEnumArguments when enumerator is not created for __callee__ and __callee__ methods. (@koic)
  • #11603: Actually run temporarily enabled cops. (@tdeo)
  • #11579: Fix an error for Layout/HeredocArgumentClosingParenthesis when heredoc is a method argument in a parenthesized block argument. (@koic)
  • #11576: Fix an error for Lint/UselessRescue when rescue does not exception variable and ensure has empty body. (@koic)
  • #11608: Fix an error for Lint/RefinementImportMethods when using include on the top level. (@koic)
  • #11589: Fix an error for Layout/HeredocArgumentClosingParenthesis when heredoc is a branch body in a method argument of a parenthesized argument. (@koic)
  • #11567: Fix Layout/EndAlignment false negative. (@j-miyake)
  • #11582: Fix checking if token with large offset begins its line. (@fatkodima)
  • #11412: Mark Style/ArrayIntersect as unsafe. (@koic)
  • #11559: Fixed false positives and negatives in Style/RedundantRegexpCharacterClass when using octal escapes (e.g. "\0"). (@jaynetics)
  • #11575: Fix parentheses in value omissions for multiple assignments. (@gsamokovarov)

Changes

  • #11586: Handle ruby2_keywords in Style/DocumentationMethod cop. (@fatkodima)
  • #11604: Make Naming/VariableNumber to allow x86_64 CPU architecture name by default. (@koic)
  • #11596: Make Style/AccessorGrouping aware of method call before accessor. (@koic)
  • #11588: Optimize Style/WordArray complex matrix check. (@sambostock)
  • #11573: Handle hash patterns and pins in Lint/OutOfRangeRegexpRef cop. (@fatkodima)
  • #11564: Remove print debug methods from default for Lint/Debugger. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Mar 17, 2023
@mkon
Copy link
Owner

mkon commented Mar 18, 2023

@depfu rebase

@depfu depfu bot force-pushed the depfu/update/rubocop-1.48.1 branch from 84b0352 to 1b4d28a Compare March 18, 2023 08:05
@mkon mkon merged commit f042060 into main Mar 18, 2023
@mkon mkon deleted the depfu/update/rubocop-1.48.1 branch March 18, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
depfu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mkon