Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rubocop-rspec to version 2.22.0 #45

Merged
merged 1 commit into from
May 31, 2023

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented May 16, 2023

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (2.20.0 → 2.22.0) · Repo · Changelog

Release Notes

2.22.0

  • Extract factory_bot cops to a separate repository, rubocop-factory_bot. The rubocop-factory_bot repository is a dependency of rubocop-rspec and the factory_bot cops are aliased (RSpec/FactoryBot/Foo == FactoryBot/Foo) until v3.0 is released, so the change will be invisible to users until then. (@ydah)

2.21.0

  • Fix a false positive in RSpec/IndexedLet with suffixes after index-like numbers. (@pirj)
  • Fix an error for RSpec/Rails/HaveHttpStatus with comparison with strings containing non-numeric characters. (@ydah)
  • Fix an error for RSpec/MatchArray when match_array with no argument. (@ydah)
  • Add support a_block_changing and changing for RSpec/ChangeByZero. (@ydah)
  • Drop Ruby 2.6 support. (@ydah)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 25 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label May 16, 2023
@mkon mkon merged commit cae6b0f into main May 31, 2023
@mkon mkon deleted the depfu/update/rubocop-rspec-2.22.0 branch May 31, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant