Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop → 1.59.0 (unknown) #80

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Update rubocop → 1.59.0 (unknown) #80

merged 1 commit into from
Jan 8, 2024

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Dec 29, 2023

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (1.57.2 → 1.59.0) · Repo · Changelog

Release Notes

1.59.0

New features

  • #12518: Add new Lint/ItWithoutArgumentsInBlock cop. (@koic)

Bug fixes

  • #12434: Fix a false positive for Lint/LiteralAssignmentInCondition when using interpolated string or xstring literals. (@koic)
  • #12435: Fix a false positive for Lint/SelfAssignment when using attribute assignment with method call with arguments. (@koic)
  • #12444: Fix false positive for Style/HashEachMethods when receiver literal is not a hash literal. (@koic)
  • #12524: Fix a false positive for Style/MethodCallWithArgsParentheses when EnforcedStyle: omit_parentheses and parens in when clause is used to pass an argument. (@koic)
  • #12505: Fix a false positive for Style/RedundantParentheses when using parenthesized lambda or proc with do...end block. (@koic)
  • #12442: Fix an incorrect autocorrect for Style/CombinableLoops when looping over the same data as previous loop in do...end and {...} blocks. (@koic)
  • #12432: Fix a false positive for Lint/LiteralAssignmentInCondition when using parallel assignment with splat operator in block of guard condition. (@koic)
  • #12441: Fix false positives for Style/HashEachMethods when using destructed block arguments. (@koic)
  • #12436: Fix false positives for Style/RedundantParentheses when a part of range is a parenthesized condition. (@koic)
  • #12429: Fix incorrect autocorrect for Style/MapToHash when using dot method calls for to_h. (@koic)
  • #12488: Make Lint/HashCompareByIdentity aware of safe navigation operator. (@koic)
  • #12489: Make Lint/NextWithoutAccumulator aware of safe navigation operator. (@koic)
  • #12490: Make Lint/NumberConversion aware of safe navigation operator. (@koic)
  • #12491: Make Lint/RedundantWithIndex aware of safe navigation operator. (@koic)
  • #12492: Make Lint/RedundantWithObject aware of safe navigation operator. (@koic)
  • #12493: Make Lint/UnmodifiedReduceAccumulator aware of safe navigation operator. (@koic)
  • #12473: Make Style/ClassCheck aware of safe navigation operator. (@koic)
  • #12445: Make Style/CollectionCompact aware of safe navigation operator. (@koic)
  • #12474: Make Style/ConcatArrayLiterals aware of safe navigation operator. (@koic)
  • #12476: Make Style/DateTime aware of safe navigation operator. (@koic)
  • #12479: Make Style/EachWithObject aware of safe navigation operator. (@koic)
  • #12446: Make Style/HashExcept aware of safe navigation operator. (@koic)
  • #12447: Make Style/MapCompactWithConditionalBlock aware of safe navigation operator. (@koic)
  • #12484: Make Style/Next aware of safe navigation operator. (@koic)
  • #12486: Make Style/RedundantArgument aware of safe navigation operator. (@koic)
  • #12454: Make Style/RedundantFetchBlock aware of safe navigation operator. (@koic)
  • #12495: Make Layout/RedundantLineBreak aware of safe navigation operator. (@koic)
  • #12455: Make Style/RedundantSortBy aware of safe navigation operator. (@koic)
  • #12456: Make Style/RedundantSortBy aware of safe navigation operator. (@koic)
  • #12480: Make Style/ExactRegexpMatch aware of safe navigation operator. (@koic)
  • #12457: Make Style/Sample aware of safe navigation operator. (@koic)
  • #12458: Make Style/SelectByRegexp cops aware of safe navigation operator. (@koic)
  • #12494: Make Layout/SingleLineBlockChain aware of safe navigation operator. (@koic)
  • #12461: Make Style/StringChars aware of safe navigation operator. (@koic)
  • #12468: Make Style/Strip aware of safe navigation operator. (@koic)
  • #12469: Make Style/UnpackFirst aware of safe navigation operator. (@koic)

Changes

  • #12522: Make Style/MethodCallWithoutArgsParentheses allow the parenthesized it method in a block. (@koic)
  • #12523: Make Style/RedundantSelf allow the self.it method in a block. (@koic)

1.58.0

New features

Bug fixes

  • #12372: Fix a false negative for Lint/Debugger when used within method arguments a begin...end block. (@koic)
  • #12378: Fix a false negative for Style/Semicolon when a semicolon at the beginning of a lambda block. (@koic)
  • #12146: Fix a false positive for Lint/FloatComparison when comparing against zero. (@earlopain)
  • #12404: Fix a false positive for Layout/RescueEnsureAlignment when aligned rescue in do-end numbered block in a method. (@koic)
  • #12374: Fix a false positive for Layout/SpaceBeforeSemicolon when a space between an opening lambda brace and a semicolon. (@koic)
  • #12326: Fix an error for Style/RedundantDoubleSplatHashBraces when method call for parenthesized no hash double double splat. (@koic)
  • #12361: Fix an incorrect autocorrect for Naming/BlockForwarding and Style/ArgumentsForwarding when autocorrection conflicts for anonymous arguments. (@koic)
  • #12324: Fix an error for Layout/RescueEnsureAlignment when using rescue in do...end block assigned to object attribute. (@koic)
  • #12322: Fix an error for Style/CombinableLoops when looping over the same data for the third consecutive time or more. (@koic)
  • #12366: Fix a false negative for Layout/ExtraSpacing when a file has exactly two comments. (@eugeneius)
  • #12373: Fix a false negative for Lint/SymbolConversion when using string interpolation. (@earlopain)
  • #12402: Fix false negatives for Style/RedundantLineContinuation when redundant line continuations for a block are used, especially without parentheses around first argument. (@koic)
  • #12311: Fix false negatives for Style/RedundantParentheses when parentheses around logical operator keywords in method definition. (@koic)
  • #12394: Fix false negatives for Style/RedundantReturn when lambda (->) ending with return. (@koic)
  • #12377: Fix false positives for Lint/Void when a collection literal that includes non-literal elements in a method definition. (@koic)
  • #12407: Fix an incorrect autocorrect for Style/MapToHash with Layout/SingleLineBlockChain. (@koic)
  • #12409: Fix an incorrect autocorrect for Lint/SafeNavigationChain when ordinary method chain exists after safe navigation leading dot method call. (@koic)
  • #12363: Fix incorrect rendering of HTML character entities in HTMLFormatter formatter. (@koic)
  • #12424: Make Style/HashEachMethods aware of safe navigation operator. (@koic)
  • #12413: Make Style/InverseMethods aware of safe navigation operator. (@koic)
  • #12408: Make Style/MapToHash aware of safe navigation operator. (@koic)

Changes

  • #12328: Make Style/AutoResourceCleanup aware of Tempfile.open. (@koic)
  • #12412: Enhance Lint/RedundantSafeNavigation to handle conversion methods with defaults. (@fatkodima)
  • #12410: Enhance Lint/SelfAssignment to check attribute assignment and key assignment. (@fatkodima)
  • #12370: Make Style/HashEachMethods aware of unused block value. (@koic)
  • #12380: Make Style/RedundantParentheses aware of lambda or proc. (@koic)
  • #12421: Make Style/SelfAssignment aware of %, ^, <<, and >> operators. (@koic)
  • #12305: Require rubocop-ast version 1.30 or greater. (@sambostock)
  • #12337: Supports EnforcedStyleForRationalLiterals option for Layout/SpaceAroundOperators. (@koic)
  • #12296: Support RedundantRestArgumentNames, RedundantKeywordRestArgumentNames, and RedundantBlockArgumentNames options for Style/ArgumentsForwarding. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Dec 29, 2023
@depfu depfu bot mentioned this pull request Dec 29, 2023
Closed
@mkon mkon merged commit 4fe33ea into main Jan 8, 2024
14 checks passed
@mkon mkon deleted the depfu/update/rubocop-1.59.0 branch January 8, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
depfu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mkon