defined constants for multiple airport option for readability

mkorkmaz · Oct 17, 2018 · 4cc93d9 · 4cc93d9
1 parent f8779b7
commit 4cc93d9
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -24,7 +24,7 @@ Use https://api.turkishairlines.com/test as your api test url during development
 ```PHP
 <?php
 
-include 'vendor/autoload.php'
+include 'vendor/autoload.php';
 use TK\SDK\ClientBuilder;
 
 $client = ClientBuilder::create()
@@ -39,8 +39,8 @@ use DateTimeImmutable;
 use TK\SDK\ValueObject;
 
 $departureTime = gmdate('Y-m-d H:i:s', strtotime('+4 days'));
-$originLocation = new ValueObject\Location('IST', true);
-$destinationLocation  = new ValueObject\Location('JFK', true);
+$originLocation = new ValueObject\Location('IST', ValueObject\Location::MILTIPLE_AIRPORT_TRUE);
+$destinationLocation  = new ValueObject\Location('JFK', ValueObject\Location::MILTIPLE_AIRPORT_TRUE);
 $departureDateTime = new ValueObject\DepartureDateTime(
 	new DateTimeImmutable($departureTime),
 	'P3D',

diff --git a/src/SDK/ValueObject/Location.php b/src/SDK/ValueObject/Location.php
@@ -7,6 +7,9 @@
 
 final class Location implements ValueObjectInterface
 {
+    public const MILTIPLE_AIRPORT_TRUE = true;
+    public const MILTIPLE_AIRPORT_FALSE = false;
+
     private $locationCode;
     private $multiAirportCityInd;
 

diff --git a/tests/unit/Endpoint/GetTimeTableTest.php b/tests/unit/Endpoint/GetTimeTableTest.php
@@ -14,8 +14,8 @@ class GetTimeTableTest extends EndpointAbstract
     public function shouldGetResponseSuccessfully() : void
     {
         $departureTime = gmdate('Y-m-d H:i:s', strtotime('+4 days'));
-        $originLocation = new ValueObject\Location('IST', true);
-        $destinationLocation  = new ValueObject\Location('JFK', true);
+        $originLocation = new ValueObject\Location('IST', ValueObject\Location::MILTIPLE_AIRPORT_TRUE);
+        $destinationLocation  = new ValueObject\Location('JFK', ValueObject\Location::MILTIPLE_AIRPORT_TRUE);
         $departureDateTime = new ValueObject\DepartureDateTime(
             new DateTimeImmutable($departureTime),
             'P3D',