Skip to content

Conversation

@BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented May 13, 2023

Lots of changes, but at the end it's a cleaner way to use a custom folder for each test. pytest will handle the auto-deletion of the temporary folder at the end of the test, no need to do it ourselves.

Going a step further, it is now useless to use force_overwrite=True when creating databases. But to ease the review, and eventual approval, I decided to not touch that part.

@mkrd
Copy link
Owner

mkrd commented May 19, 2023

@BoboTiG That's a lot cleaner, thanks for your contribution 👍

@mkrd mkrd merged commit c23a92b into mkrd:main May 19, 2023
@BoboTiG BoboTiG deleted the impr-use-pytest-fixture-tmp_path branch May 19, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants