Fixed bug "Convert hex string to decimal number #58" and made String init() 23 times faster with 60K digits. #59
Conversation
Used Measure values for the sizeDescription. Optimized the init?(String) function.
| @@ -20,6 +20,12 @@ class BIntTests: XCTestCase { | |||
| // Put teardown code here. This method is called after the invocation of each test method in the class. | |||
| super.tearDown() | |||
| } | |||
|
|
|||
| // func testSizeString() | |||
There was a problem hiding this comment.
Remove or actually implement
There was a problem hiding this comment.
Removed it. A remnant of a test of mine.
| @@ -17,6 +17,7 @@ protocol NumericType: | |||
|
|
|||
| extension Double: NumericType | |||
| { | |||
| // FIXME: Compiler warns about function call causing infinite recursion - MG | |||
There was a problem hiding this comment.
Are you planning on actually fixing these warnings in this PR?
There was a problem hiding this comment.
Fixed it. It turns out this was implemented elsewhere so I just deleted the code.
| return String(self[start..<end]) | ||
| } | ||
| } | ||
| // FIXME: The *split* causes a massive overhead due to *self* calls. Please remove. |
There was a problem hiding this comment.
If split isn't used anymore then please remove this extension entirely.
| @@ -1257,6 +1280,11 @@ fileprivate extension Array where Element == Limb | |||
|
|
|||
| /// Returns the number of bits that contribute to the represented number, ignoring all | |||
| /// leading zeros. | |||
|
|
|||
| // FIXME: - Not the correct definition of *bitWidth* according to Apple - MG 6 Feb 2022 | |||
There was a problem hiding this comment.
Please add a unit test to match the correct definition
There was a problem hiding this comment.
Can't do, the Limb bitWidth is fileprivate. Instead, I changed the name to exactBitWidth and updated the places where it is used. The implementation is unchanged.
|
I'll submit an updated pull request shortly. |
I fixed a few things including bug #58 with my merging of the different String init() functions. As a bonus, this init() is now about 23 times faster than it was and much easier to use. Overall, I was impressed by the speed of the various features with this one exception — so I had to fix it. 😉
I also fixed your magnitude function which now works correctly (at least how Apple intended).
BTW, I recommend removing the String.split since it was one major element responsible for slowing down the init().
I also noticed a bug with the random number creation where the bit sizes would be incorrect sometimes. This led me down a rabbit-hole in checking the true definition of the bitSize which is not defined how one would think. It is supposed to specify the actual size of the type on the underlying hardware — not the number of bits in a number as most people think. You can verify how Apple views this by performing the simple test: Int32(1).bitWidth = 32, not 1. Perhaps we need to define a new attribute like
actualBitWidth.I added some tags so that the Swift Package versions work correctly. The SPM does not like 'v's in front of the version numbers.
Overall, I really like the work you've done and may contribute some more bits and pieces.