Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Dynamic ModelType #123

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

johnmai-dev
Copy link
Contributor

The Swift Package is inconvenient to modify, so I want to change ModelType to dynamic configuration.

Example:

ModelType.registerModelType("Llama5") { url in
    let configuration = try JSONDecoder().decode(Llama5Configuration.self, from: Data(contentsOf: url))
                return Llama5Model(configuration)
}

@davidkoski
Copy link
Collaborator

Looks like a nice improvement!

@davidkoski davidkoski merged commit 00edfcc into ml-explore:main Sep 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants