Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use int64_t instead of ssize_t #1673

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Use int64_t instead of ssize_t #1673

merged 1 commit into from
Dec 8, 2024

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Dec 8, 2024

Refs #1513.

ssize_t is a POSIX type and not available in MSVC, I think int64_t should do the same.

awni
awni approved these changes Dec 8, 2024
View reviewed changes
Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@awni awni merged commit 6f316b8 into ml-explore:main Dec 8, 2024
5 checks passed
@jeethu
Copy link
Contributor

jeethu commented Dec 8, 2024

ptrdiff_t is available in MSVC and everywhere else. IMO, that's a better replacement for ssize_t than hardcoding it to int64_t.

@zcbenz zcbenz mentioned this pull request Dec 9, 2024
Merged
@zcbenz zcbenz deleted the msvc-ssize branch December 9, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awni awni awni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zcbenz @jeethu @awni