Work around function std name collision in MSVC #1679
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1513.
There is a bug in MSVC that, if the
std
function is exposed to current scope withusing namespace mlx::core
, all followingstd::xxx
invocations that try to access thenamespace std
will fail with very unhelpful errors:(MSVC thinks
std::
is ambiguous.)There are 2 solutions, one taken by this PR is to rename the
std
function tostd_dev
and use it internally, while adding astd
alias only available in publicmlx.h
header. It makes minimum changes to existing code with the cost of adding a new header.The other solution would be replacing the
using namespace mlx::core
withnamespace mx = mlx::core
and usemx::xxx()
instead ofxxx()
in the python bindings code. I prefer this one but it would result in a relatively large PR.