Fix library output directory for MSVC #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awni
reviewed
Dec 9, 2024
python/src/CMakeLists.txt
Outdated
Comment on lines
32
to
46
| if(MSVC) | ||
| set_target_properties( | ||
| core | ||
| PROPERTIES LIBRARY_OUTPUT_DIRECTORY_RELEASE | ||
| ${MLX_PYTHON_BINDINGS_OUTPUT_DIRECTORY} | ||
| LIBRARY_OUTPUT_DIRECTORY_DEBUG | ||
| ${MLX_PYTHON_BINDINGS_OUTPUT_DIRECTORY} | ||
| LIBRARY_OUTPUT_DIRECTORY_RELWITHDEBINFO | ||
| ${MLX_PYTHON_BINDINGS_OUTPUT_DIRECTORY} | ||
| LIBRARY_OUTPUT_DIRECTORY_MINSIZEREL | ||
| ${MLX_PYTHON_BINDINGS_OUTPUT_DIRECTORY}) | ||
| else() | ||
| set_target_properties(core PROPERTIES LIBRARY_OUTPUT_DIRECTORY | ||
| ${MLX_PYTHON_BINDINGS_OUTPUT_DIRECTORY}) | ||
| endif() |
There was a problem hiding this comment.
Why not just use the first condition for every platform and discard the check for MSVC?
There was a problem hiding this comment.
Updated. It seems that some build systems other than MSVC also require this to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1513.
For MSVC you have to specify library output dir for every config otherwise the file would be put into
out/Debug,out/Release, etc. instead ofoutdirectly.