Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use psutil to get memory info on Windows #1700

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Dec 14, 2024

Refs #1513.

The resource package does not work on Windows, and according to giampaolo/psutil#1096, the equivalent of ru_maxrss is peak_wset on Windows.

Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@awni awni merged commit dfccd17 into ml-explore:main Dec 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants