Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dilation for convolutional layers #766

Merged
merged 5 commits into from
Mar 4, 2024
Merged

Dilation for convolutional layers #766

merged 5 commits into from
Mar 4, 2024

Conversation

a1eaiactaest
Copy link
Contributor

@a1eaiactaest a1eaiactaest commented Mar 1, 2024 •
edited
Loading

Dilation for convolutional layers

Adding dilation parameter to nn.Conv1d and nn.Conv2d layers.
Reference: #765

Checklist

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

@a1eaiactaest a1eaiactaest mentioned this pull request Mar 1, 2024
Closed
@a1eaiactaest
Copy link
Contributor Author

Added tests for Conv1d and Conv2d, but not sure if they're sufficient enough. LMK @awni

@a1eaiactaest a1eaiactaest marked this pull request as ready for review March 4, 2024 12:35
@a1eaiactaest
Copy link
Contributor Author

Marked as ready for review, still need to add documentation though.

@a1eaiactaest
Copy link
Contributor Author

Not sure how the change in the docs works. @awni would you mind helping me here?

awni
awni approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! The docs will be updated the next time we build them.

@awni awni merged commit 6a665ea into ml-explore:main Mar 4, 2024
4 checks passed
@a1eaiactaest a1eaiactaest mentioned this pull request Mar 5, 2024
Open
awni pushed a commit that referenced this pull request Mar 5, 2024
@a1eaiactaest @awni
Dilation for convolutional layers (#766)
2aa71d4 
* add dilation parameter to Conv1d layer

* space here too

* add conv1d dilation test

* add dilation parameter for Conv2d layer

* conv2d dilation test
@jimexist jimexist mentioned this pull request Mar 7, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awni awni awni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a1eaiactaest @awni